From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:57204 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933436AbeFKQYQ (ORCPT ); Mon, 11 Jun 2018 12:24:16 -0400 Date: Mon, 11 Jun 2018 09:24:12 -0700 From: Christoph Hellwig To: Miklos Szeredi Cc: Al Viro , Christoph Hellwig , Miklos Szeredi , overlayfs , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/39] vfs: export vfs_ioctl() to modules Message-ID: <20180611162412.GA7574@infradead.org> References: <20180529144339.16538-1-mszeredi@redhat.com> <20180529144339.16538-8-mszeredi@redhat.com> <20180604084904.GF11333@infradead.org> <20180610045657.GM30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jun 11, 2018 at 09:19:01AM +0200, Miklos Szeredi wrote: > We don't. Obviously need to make sure to only ever do ioctl's in > overlayfs that have a common definition across filesystems. Not a lot > of those, luckily... Which are those? If they are common and possibly called from kernel code they should probably be made into methods instead.