From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:35918 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932394AbeFKUQ6 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Mon, 11 Jun 2018 16:16:58 -0400
Date: Mon, 11 Jun 2018 21:16:56 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Andrey Vagin <avagin@virtuozzo.com>,
        Linux FS Devel <linux-fsdevel@vger.kernel.org>
Subject: Re: [1/4] vmsplice: lift import_iovec() into do_vmsplice()
Message-ID: <20180611201656.GX30522@ZenIV.linux.org.uk>
References: <20180528222013.18402-1-viro@ZenIV.linux.org.uk>
 <20180606225751.GA1261@outlook.office365.com>
 <20180607175622.GA12359@outlook.office365.com>
 <CAM5jBj5Q5ZLURn_jqk+TQpDsLe6g7Ou-ju=sqdHBFjkHk=D-uw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAM5jBj5Q5ZLURn_jqk+TQpDsLe6g7Ou-ju=sqdHBFjkHk=D-uw@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, Jun 11, 2018 at 11:14:55PM +0300, Cyrill Gorcunov wrote:
> On Thu, Jun 7, 2018 at 10:07 PM Andrei Vagin <avagin@virtuozzo.com> wrote:
> >
> ...
> > > > +
> > > > +   error = import_iovec(READ, uiov, nr_segs,
> > > > +                      ARRAY_SIZE(iovstack), &iov, &iter);
> > >
> > > import_iovec should be called with WRITE, if we are going to call
> > > vmsplice_to_pipe().
> >
> > We caught this issue, when we run CRIU tests for
> > https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/log/?h=for-next
> >
> > CRIU fails with errors like this:
> >
> > pie: 38: Error (criu/pie/parasite.c:89): Can't splice pages to pipe (-14/2/0)
> >
> It is already in the master tree, or still in the linux-next?

Still in -next; I have a fixed variant, hadn't pushed it out yet.