From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:35230 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753517AbeFMDGQ (ORCPT ); Tue, 12 Jun 2018 23:06:16 -0400 Date: Tue, 12 Jun 2018 23:06:01 -0400 From: "Theodore Y. Ts'o" To: Mark Fasheh Cc: Carlos Maiolino , "Darrick J. Wong" , Eric Sandeen , linux-fsdevel@vger.kernel.org, david@fromorbit.com, hch@infradead.org Subject: Re: Ext4 fiemap implementation Message-ID: <20180613030601.GB3340@thunk.org> References: <20180601123621.avcgzyedbiqxlktf@odin.usersys.redhat.com> <20180603032853.GA3585@thunk.org> <20180604164309.GB23842@magnolia> <20180608224126.GD28053@wotan.suse.de> <20180611072827.arsyq56m7ptnedig@odin.usersys.redhat.com> <20180612235203.GE28053@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180612235203.GE28053@wotan.suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jun 13, 2018 at 01:52:03AM +0200, Mark Fasheh wrote: > > > > So, you are saying iomap implementation violates FIEMAP specs? > > Does iomap do this or just XFS? At any rate, the doc should be read > as Ted suggests: '"Extents returned mirror those on disk" as meaning > that the ext4 behavior is *mandated* by the docs.' > > So anything that's mainipulating the returned extents solely to > 'fit' them into a request is wrong. Well, or the FIEMAP specs could be changed. If I recall correctly the FIEMAP implementation by the various file systems predates the documentation. I suspect whoever wrote the docs looked at the ext2/ext3/ext4 implementation and used that to write the documentation. If other file systems were doing something else, I'd be in favor of allowing either behavior, since userspace programs who care will need to accomodate either behavior. Fortunately, I suspect it matters for very few (if any) userspace programs. - Ted