linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] include: dax: new-return-type-vm_fault_t
@ 2018-06-20 17:20 Souptick Joarder
  2018-06-20 17:21 ` Souptick Joarder
  0 siblings, 1 reply; 3+ messages in thread
From: Souptick Joarder @ 2018-06-20 17:20 UTC (permalink / raw)
  To: willy, dan.j.williams, jack, kirill.shutemov, mhocko, akpm,
	ross.zwisler, viro
  Cc: linux-fsdevel, linux-mm

Use new return type vm_fault_t for fault handler. For now,
this is just documenting that the function returns a VM_FAULT
value rather than an errno. Once all instances are converted,
vm_fault_t will become a distinct type.

commit 1c8f422059ae ("mm: change return type to vm_fault_t")

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 include/linux/dax.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/dax.h b/include/linux/dax.h
index 7fddea8..11852d2 100644
--- a/include/linux/dax.h
+++ b/include/linux/dax.h
@@ -122,7 +122,7 @@ size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
 
 ssize_t dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
 		const struct iomap_ops *ops);
-int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,
+vm_fault_t dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,
 		    pfn_t *pfnp, int *errp, const struct iomap_ops *ops);
 vm_fault_t dax_finish_sync_fault(struct vm_fault *vmf,
 		enum page_entry_size pe_size, pfn_t pfn);
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] include: dax: new-return-type-vm_fault_t
  2018-06-20 17:20 [PATCH] include: dax: new-return-type-vm_fault_t Souptick Joarder
@ 2018-06-20 17:21 ` Souptick Joarder
  2018-06-20 17:27   ` Matthew Wilcox
  0 siblings, 1 reply; 3+ messages in thread
From: Souptick Joarder @ 2018-06-20 17:21 UTC (permalink / raw)
  To: Matthew Wilcox, Dan Williams, Jan Kara, Kirill A. Shutemov,
	Michal Hocko, Andrew Morton, Ross Zwisler, Al Viro
  Cc: linux-fsdevel, Linux-MM

On Wed, Jun 20, 2018 at 10:50 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> Use new return type vm_fault_t for fault handler. For now,
> this is just documenting that the function returns a VM_FAULT
> value rather than an errno. Once all instances are converted,
> vm_fault_t will become a distinct type.
>
> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  include/linux/dax.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dax.h b/include/linux/dax.h
> index 7fddea8..11852d2 100644
> --- a/include/linux/dax.h
> +++ b/include/linux/dax.h
> @@ -122,7 +122,7 @@ size_t dax_copy_from_iter(struct dax_device *dax_dev, pgoff_t pgoff, void *addr,
>
>  ssize_t dax_iomap_rw(struct kiocb *iocb, struct iov_iter *iter,
>                 const struct iomap_ops *ops);
> -int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,
> +vm_fault_t dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size,
>                     pfn_t *pfnp, int *errp, const struct iomap_ops *ops);
>  vm_fault_t dax_finish_sync_fault(struct vm_fault *vmf,
>                 enum page_entry_size pe_size, pfn_t pfn);
> --
> 1.9.1
>

Matthew/ Andrew,

As part of
commit ab77dab46210 ("fs/dax.c: use new return type vm_fault_t")
I missed this change which leads to compilation error.
Sorry about it.

This patch need to be in 4.18-rc-2/x on priority.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] include: dax: new-return-type-vm_fault_t
  2018-06-20 17:21 ` Souptick Joarder
@ 2018-06-20 17:27   ` Matthew Wilcox
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2018-06-20 17:27 UTC (permalink / raw)
  To: Souptick Joarder
  Cc: Dan Williams, Jan Kara, Kirill A. Shutemov, Michal Hocko,
	Andrew Morton, Ross Zwisler, Al Viro, linux-fsdevel, Linux-MM

On Wed, Jun 20, 2018 at 10:51:49PM +0530, Souptick Joarder wrote:
> On Wed, Jun 20, 2018 at 10:50 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote:
> > Use new return type vm_fault_t for fault handler. For now,
> > this is just documenting that the function returns a VM_FAULT
> > value rather than an errno. Once all instances are converted,
> > vm_fault_t will become a distinct type.

> As part of
> commit ab77dab46210 ("fs/dax.c: use new return type vm_fault_t")
> I missed this change which leads to compilation error.
> Sorry about it.
> 
> This patch need to be in 4.18-rc-2/x on priority.

It only leads to a compilation error for you; the rest of us are still
using typedef int vm_fault_t, so it's not a mismatch.  It'd be nice to get
this fixed, but it's not a priority.

Sorry I didn't spot this during my review.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-06-20 17:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-20 17:20 [PATCH] include: dax: new-return-type-vm_fault_t Souptick Joarder
2018-06-20 17:21 ` Souptick Joarder
2018-06-20 17:27   ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).