From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, dhowells@redhat.com,
viro@ZenIV.linux.org.uk, Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 3/3] VFS: call d_inode() from d_backing_inode()
Date: Thu, 21 Jun 2018 07:58:16 -0500 [thread overview]
Message-ID: <20180621125816.254kg3zx2tptmvfq@merlin> (raw)
In-Reply-To: <20180621122201.GB14053@infradead.org>
On 06-21 05:22, Christoph Hellwig wrote:
> On Wed, Jun 20, 2018 at 02:39:10PM -0500, Goldwyn Rodrigues wrote:
> > -static inline struct dentry *d_backing_dentry(struct dentry *upper)
> > +static inline struct inode *d_backing_inode(const struct dentry *dentry)
> > {
> > - return upper;
> > + return d_inode(dentry);
> > }
>
> Why even keep both functions around then?
>
Yes, I would love to get rid of them. There are just too many users.
1332 users of d_inode
176 users of d_backing_inode
Similarly, file_inode() with 1020 users is another candidate.
Introduced in -
496ad9aa8ef4 ("new helper: file_inode(file)")
but made unnecessary in -
dd37978c50bc ("cache the value of file_inode() in struct file")
I will work on a patch to clean all.
--
Goldwyn
next prev parent reply other threads:[~2018-06-21 12:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 19:39 [PATCH 0/3] VFS: Revert irrelevant dcache patches Goldwyn Rodrigues
2018-06-20 19:39 ` [PATCH 1/3] Revert: "VFS: Add a fallthrough flag for marking virtual dentries" Goldwyn Rodrigues
2018-06-20 19:39 ` [PATCH 2/3] Revert: "VFS: Add a whiteout dentry type" Goldwyn Rodrigues
2018-06-20 19:39 ` [PATCH 3/3] VFS: call d_inode() from d_backing_inode() Goldwyn Rodrigues
2018-06-21 12:22 ` Christoph Hellwig
2018-06-21 12:58 ` Goldwyn Rodrigues [this message]
2018-06-21 13:01 ` Christoph Hellwig
2018-06-21 13:40 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180621125816.254kg3zx2tptmvfq@merlin \
--to=rgoldwyn@suse.de \
--cc=dhowells@redhat.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).