From: Jan Kara <jack@suse.cz>
To: Paul Moore <paul@paul-moore.com>
Cc: amir73il@gmail.com, jack@suse.cz, linux-audit@redhat.com,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
rgb@redhat.com
Subject: Re: [PATCH 0/6] audit: Fix various races when tagging and untagging mounts
Date: Tue, 3 Jul 2018 16:14:17 +0200 [thread overview]
Message-ID: <20180703141417.fcf6znn3jjcvzaoa@quack2.suse.cz> (raw)
In-Reply-To: <CAHC9VhTMOKGJu0JvAUuVRYmBvSq18oguhr9ufO6NF7w=LbRLew@mail.gmail.com>
On Fri 29-06-18 14:01:44, Paul Moore wrote:
> On Fri, Jun 29, 2018 at 7:44 AM Amir Goldstein <amir73il@gmail.com> wrote:
> > On Thu, Jun 28, 2018 at 7:40 PM, Jan Kara <jack@suse.cz> wrote:
> > > Hello,
> > >
> > > this series addresses the problems I have identified when trying to understand
> > > how exactly is kernel/audit_tree.c using generic fsnotify framework. I hope
> > > I have understood all the interactions right but careful review is certainly
> > > welcome (CCing Al as he was the one implementing this code originally).
> > >
> > > The patches have been tested by a stress test I have written which mounts &
> > > unmounts filesystems in the directory tree while adding and removing audit
> > > rules for this tree in parallel and accessing the tree to generate events.
> > > Still some real-world testing would be welcome.
> > >
> >
> > This sort of stress test sound really useful to fanotify/inotify as well.
> > Do plan to upstream that stress test?
>
> Agreed.
>
> I would be interested in having something like this in the
> audit-testsuite so that we can include it in our regular regression
> testing.
>
> * https://github.com/linux-audit/audit-testsuite
OK, I'll look into integrating the test script into audit testsuite.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2018-07-03 14:14 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 16:40 [PATCH 0/6] audit: Fix various races when tagging and untagging mounts Jan Kara
2018-06-28 16:40 ` [PATCH 1/6] audit_tree: Replace mark->lock locking Jan Kara
2018-06-29 11:31 ` Amir Goldstein
2018-07-03 14:07 ` Jan Kara
2018-06-28 16:40 ` [PATCH 2/6] audit: Fix possible spurious -ENOSPC error Jan Kara
2018-06-29 11:42 ` Amir Goldstein
2018-07-02 6:05 ` Dan Carpenter
2018-07-03 14:18 ` Jan Kara
2018-06-28 16:40 ` [PATCH 3/6] audit: Fix possible tagging failures Jan Kara
2018-06-29 12:05 ` Amir Goldstein
2018-07-03 14:21 ` Jan Kara
2018-07-03 17:42 ` Amir Goldstein
2018-07-04 8:28 ` Jan Kara
2018-06-28 16:40 ` [PATCH 4/6] audit: Embed key into chunk Jan Kara
2018-06-29 12:53 ` Amir Goldstein
2018-07-03 14:25 ` Jan Kara
2018-06-28 16:40 ` [PATCH 5/6] audit: Make hash table insertion safe against concurrent lookups Jan Kara
2018-06-29 13:02 ` Amir Goldstein
2018-07-03 15:31 ` Jan Kara
2018-06-28 16:40 ` [PATCH 6/6] audit: Point to fsnotify mark instead of embedding it Jan Kara
2018-06-29 13:20 ` Amir Goldstein
2018-07-04 12:34 ` Jan Kara
2018-06-29 11:44 ` [PATCH 0/6] audit: Fix various races when tagging and untagging mounts Amir Goldstein
2018-06-29 18:01 ` Paul Moore
2018-07-03 14:14 ` Jan Kara [this message]
2018-07-03 17:03 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703141417.fcf6znn3jjcvzaoa@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=rgb@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).