From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:45470 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752839AbeGCV63 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 3 Jul 2018 17:58:29 -0400
Date: Tue, 3 Jul 2018 22:58:26 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Howells <dhowells@redhat.com>
Cc: Eric Biggers <ebiggers3@gmail.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH 10/32] VFS: Implement a filesystem superblock
 creation/configuration context [ver #8]
Message-ID: <20180703215825.GX30522@ZenIV.linux.org.uk>
References: <20180703183325.GA210265@gmail.com>
 <152720672288.9073.9868393448836301272.stgit@warthog.procyon.org.uk>
 <152720678933.9073.11201500538963619904.stgit@warthog.procyon.org.uk>
 <14124.1530654802@warthog.procyon.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <14124.1530654802@warthog.procyon.org.uk>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jul 03, 2018 at 10:53:22PM +0100, David Howells wrote:
> -				if (s) {
> -					up_write(&s->s_umount);
> +				if (s)
>  					destroy_unused_super(s);

static void destroy_unused_super(struct super_block *s)
{
        if (!s)
                return;
	...
}

IOW, all of those should be unconditional.