From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pg1-f193.google.com ([209.85.215.193]:38400 "EHLO
        mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753993AbeGGV22 (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Sat, 7 Jul 2018 17:28:28 -0400
Received: by mail-pg1-f193.google.com with SMTP id k3-v6so579991pgq.5
        for <linux-fsdevel@vger.kernel.org>; Sat, 07 Jul 2018 14:28:28 -0700 (PDT)
Date: Sat, 7 Jul 2018 14:28:25 -0700
From: Omar Sandoval <osandov@osandov.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        Alexey Dobriyan <adobriyan@gmail.com>,
        Eric Biederman <ebiederm@xmission.com>, kernel-team@fb.com
Subject: Re: [PATCH 5/7] proc/kcore: clean up ELF header generation
Message-ID: <20180707212825.GA23366@vader>
References: <196479b479237502d4d8b0e5a562b52205e5c374.1530904769.git.osandov@fb.com>
 <201807071557.QxJwgEfj%fengguang.wu@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201807071557.QxJwgEfj%fengguang.wu@intel.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Jul 07, 2018 at 06:05:17PM +0800, kbuild test robot wrote:
> Hi Omar,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.18-rc3 next-20180706]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Omar-Sandoval/proc-kcore-improvements/20180707-052548
> reproduce:
>         # apt-get install sparse
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__
> 
> 
> sparse warnings: (new ones prefixed by >>)
> 
>    include/linux/nodemask.h:265:16: sparse: expression using sizeof(void)
>    include/linux/nodemask.h:271:16: sparse: expression using sizeof(void)
> >> fs//proc/kcore.c:328:23: sparse: expression using sizeof(void)
> >> fs//proc/kcore.c:328:23: sparse: expression using sizeof(void)

Not sure why this confuses sparse. Maybe because it's #define elfhdr
elf64_hdr.

>    fs//proc/kcore.c:368:23: sparse: expression using sizeof(void)
>    fs//proc/kcore.c:368:23: sparse: expression using sizeof(void)
> >> fs//proc/kcore.c:384:49: sparse: missing braces around initializer

This is

>  > 384			struct elf_prstatus prstatus = {0};

GCC doesn't complain, but I guess I can change it to "= {};", which
isn't strict C89 but both GCC and sparse are happy with.