From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f195.google.com ([209.85.192.195]:45460 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074AbeGHVFf (ORCPT ); Sun, 8 Jul 2018 17:05:35 -0400 From: Eric Biggers To: David Howells , Alexander Viro , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Eric Biggers Subject: [PATCH 02/18] fs_context: fix shrinker leak in sget_fc() Date: Sun, 8 Jul 2018 14:01:38 -0700 Message-Id: <20180708210154.10423-3-ebiggers3@gmail.com> In-Reply-To: <20180708210154.10423-1-ebiggers3@gmail.com> References: <20180708210154.10423-1-ebiggers3@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: From: Eric Biggers alloc_super() now preallocates the shrinker, so sget_fc() must only register the pre-allocated shrinker, not allocate one again. Fixes: 8a2e54b8af88 ("vfs: Implement a filesystem superblock creation/configuration context") Signed-off-by: Eric Biggers --- fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/super.c b/fs/super.c index e6052a72f3558..a992dd0f27670 100644 --- a/fs/super.c +++ b/fs/super.c @@ -559,7 +559,7 @@ struct super_block *sget_fc(struct fs_context *fc, hlist_add_head(&s->s_instances, &s->s_type->fs_supers); spin_unlock(&sb_lock); get_filesystem(s->s_type); - register_shrinker(&s->s_shrink); + register_shrinker_prepared(&s->s_shrink); return s; } EXPORT_SYMBOL(sget_fc); -- 2.18.0