From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: [PATCH 05/18] fs_context: fix mount option blacklist
Date: Sun, 8 Jul 2018 14:01:41 -0700 [thread overview]
Message-ID: <20180708210154.10423-6-ebiggers3@gmail.com> (raw)
In-Reply-To: <20180708210154.10423-1-ebiggers3@gmail.com>
From: Eric Biggers <ebiggers@google.com>
The blacklist didn't actually do anything, since match_token() always
returned 0.
Fixes: 8a2e54b8af88 ("vfs: Implement a filesystem superblock creation/configuration context")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
fs/fs_context.c | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/fs/fs_context.c b/fs/fs_context.c
index a0e22f4c6b64a..7a8d1ed34ae71 100644
--- a/fs/fs_context.c
+++ b/fs/fs_context.c
@@ -65,26 +65,26 @@ static const match_table_t common_clear_sb_flag = {
};
static const match_table_t forbidden_sb_flag = {
- { 0, "bind" },
- { 0, "move" },
- { 0, "private" },
- { 0, "remount" },
- { 0, "shared" },
- { 0, "slave" },
- { 0, "unbindable" },
- { 0, "rec" },
- { 0, "noatime" },
- { 0, "relatime" },
- { 0, "norelatime" },
- { 0, "strictatime" },
- { 0, "nostrictatime" },
- { 0, "nodiratime" },
- { 0, "dev" },
- { 0, "nodev" },
- { 0, "exec" },
- { 0, "noexec" },
- { 0, "suid" },
- { 0, "nosuid" },
+ { 1, "bind" },
+ { 1, "move" },
+ { 1, "private" },
+ { 1, "remount" },
+ { 1, "shared" },
+ { 1, "slave" },
+ { 1, "unbindable" },
+ { 1, "rec" },
+ { 1, "noatime" },
+ { 1, "relatime" },
+ { 1, "norelatime" },
+ { 1, "strictatime" },
+ { 1, "nostrictatime" },
+ { 1, "nodiratime" },
+ { 1, "dev" },
+ { 1, "nodev" },
+ { 1, "exec" },
+ { 1, "noexec" },
+ { 1, "suid" },
+ { 1, "nosuid" },
{ },
};
--
2.18.0
next prev parent reply other threads:[~2018-07-08 21:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 21:01 [PATCH vfs/for-next 00/18] fs_context fixes Eric Biggers
2018-07-08 21:01 ` [PATCH 01/18] sysfs: check return value of kernfs_get_tree() Eric Biggers
2018-07-08 21:01 ` [PATCH 02/18] fs_context: fix shrinker leak in sget_fc() Eric Biggers
2018-07-08 21:01 ` [PATCH 03/18] fs_context: fix detecting full log buffer Eric Biggers
2018-07-08 21:01 ` [PATCH 04/18] fs_context: fix fs_context leak in simple_pin_fs() Eric Biggers
2018-07-08 21:01 ` Eric Biggers [this message]
2018-07-08 21:01 ` [PATCH 06/18] fs_context: fix memory leak with 's' (source) command Eric Biggers
2018-07-08 21:01 ` [PATCH 07/18] fs_context: fix double free of legacy_fs_context data Eric Biggers
2018-07-08 21:01 ` [PATCH 08/18] fsmount: pass up error code from dentry_open() Eric Biggers
2018-07-08 21:01 ` [PATCH 09/18] fsmount: fix handling FSMOUNT_CLOEXEC Eric Biggers
2018-07-08 21:01 ` [PATCH 10/18] fsmount: fix bypassing SB_MANDLOCK permission check Eric Biggers
2018-07-08 21:01 ` [PATCH 11/18] fspick: fix path leak Eric Biggers
2018-07-08 21:01 ` [PATCH 12/18] fspick: add missing permission check Eric Biggers
2018-07-08 21:01 ` [PATCH 13/18] fsmount: removed unused variable 'inode' Eric Biggers
2018-07-08 21:01 ` [PATCH 14/18] fsopen,fspick: factor out log allocation Eric Biggers
2018-07-08 21:01 ` [PATCH 15/18] fsopen,fspick: rename fsopen_create_fd() to fscontext_create_fd() Eric Biggers
2018-07-08 21:01 ` [PATCH 16/18] fs_context: de-obfuscate control flow in fscontext_read() Eric Biggers
2018-07-08 21:01 ` [PATCH 17/18] fs_context: de-obfuscate command validation Eric Biggers
2018-07-08 21:01 ` [PATCH 18/18] fs_context: fix fscontext_write() comment Eric Biggers
2018-07-08 23:46 ` [PATCH vfs/for-next 00/18] fs_context fixes Eric Biggers
2018-07-09 9:32 ` [PATCH 03/18] fs_context: fix detecting full log buffer David Howells
2018-07-09 9:35 ` David Howells
2018-07-09 12:31 ` [PATCH 07/18] fs_context: fix double free of legacy_fs_context data David Howells
2018-07-10 1:17 ` Eric Biggers
2018-07-10 1:25 ` Eric Biggers
2018-07-10 8:02 ` David Howells
2018-07-09 15:31 ` [PATCH vfs/for-next 00/18] fs_context fixes David Howells
2018-07-09 15:56 ` Al Viro
2018-07-09 16:28 ` David Howells
2018-07-09 21:57 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180708210154.10423-6-ebiggers3@gmail.com \
--to=ebiggers3@gmail.com \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).