From: kbuild test robot <lkp@intel.com>
To: john.hubbard@gmail.com
Cc: kbuild-all@01.org, Matthew Wilcox <willy@infradead.org>,
Michal Hocko <mhocko@kernel.org>,
Christopher Lameter <cl@linux.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
Dan Williams <dan.j.williams@intel.com>, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
linux-rdma <linux-rdma@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 1/2] mm: introduce put_user_page(), placeholder version
Date: Mon, 9 Jul 2018 18:08:14 +0800 [thread overview]
Message-ID: <201807091833.xMr1iYDX%fengguang.wu@intel.com> (raw)
In-Reply-To: <20180709080554.21931-2-jhubbard@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 2741 bytes --]
Hi John,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc4 next-20180709]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/john-hubbard-gmail-com/mm-fs-put_user_page-proposal/20180709-173653
config: x86_64-randconfig-x015-201827 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
Note: the linux-review/john-hubbard-gmail-com/mm-fs-put_user_page-proposal/20180709-173653 HEAD 3f7da023c5e08e49489e39be9cde820b0d1ab4d6 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
>> drivers/platform//goldfish/goldfish_pipe.c:334:13: error: conflicting types for 'release_user_pages'
static void release_user_pages(struct page **pages, int pages_count,
^~~~~~~~~~~~~~~~~~
In file included from include/linux/scatterlist.h:8:0,
from include/linux/dma-mapping.h:11,
from drivers/platform//goldfish/goldfish_pipe.c:62:
include/linux/mm.h:933:20: note: previous definition of 'release_user_pages' was here
static inline void release_user_pages(struct page **pages,
^~~~~~~~~~~~~~~~~~
vim +/release_user_pages +334 drivers/platform//goldfish/goldfish_pipe.c
726ea1a8 Jin Qian 2017-04-20 333
726ea1a8 Jin Qian 2017-04-20 @334 static void release_user_pages(struct page **pages, int pages_count,
726ea1a8 Jin Qian 2017-04-20 335 int is_write, s32 consumed_size)
c89f2750 David 'Digit' Turner 2013-01-21 336 {
726ea1a8 Jin Qian 2017-04-20 337 int i;
c89f2750 David 'Digit' Turner 2013-01-21 338
726ea1a8 Jin Qian 2017-04-20 339 for (i = 0; i < pages_count; i++) {
726ea1a8 Jin Qian 2017-04-20 340 if (!is_write && consumed_size > 0)
726ea1a8 Jin Qian 2017-04-20 341 set_page_dirty(pages[i]);
726ea1a8 Jin Qian 2017-04-20 342 put_page(pages[i]);
726ea1a8 Jin Qian 2017-04-20 343 }
726ea1a8 Jin Qian 2017-04-20 344 }
726ea1a8 Jin Qian 2017-04-20 345
:::::: The code at line 334 was first introduced by commit
:::::: 726ea1a8ea96b2bba34ee2073b58f0770800701c goldfish_pipe: An implementation of more parallel pipe
:::::: TO: Jin Qian <jinqian@android.com>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 26781 bytes --]
next prev parent reply other threads:[~2018-07-09 10:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 8:05 [PATCH 0/2] mm/fs: put_user_page() proposal john.hubbard
2018-07-09 8:05 ` [PATCH 1/2] mm: introduce put_user_page(), placeholder version john.hubbard
2018-07-09 10:08 ` kbuild test robot [this message]
2018-07-09 18:48 ` John Hubbard
2018-07-09 15:53 ` Jason Gunthorpe
2018-07-09 16:11 ` Jan Kara
2018-07-09 8:05 ` [PATCH 2/2] goldfish_pipe/mm: convert to the new put_user_page() call john.hubbard
2018-07-09 8:49 ` [PATCH 0/2] mm/fs: put_user_page() proposal Nicholas Piggin
2018-07-09 16:08 ` Jan Kara
2018-07-09 17:16 ` Matthew Wilcox
2018-07-09 19:47 ` Jan Kara
2018-07-09 19:56 ` Jason Gunthorpe
2018-07-10 7:51 ` Jan Kara
2018-07-09 20:00 ` Matthew Wilcox
2018-07-10 8:21 ` Jan Kara
2018-07-09 16:27 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201807091833.xMr1iYDX%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=cl@linux.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).