From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:47108 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732277AbeGKCpu (ORCPT ); Tue, 10 Jul 2018 22:45:50 -0400 Date: Wed, 11 Jul 2018 03:43:48 +0100 From: Al Viro To: Linus Torvalds Cc: linux-fsdevel , Linux Kernel Mailing List , Miklos Szeredi Subject: Re: [RFC][PATCH 04/42] make get_empty_filp() to call file_free_rcu() directly Message-ID: <20180711024348.GP30522@ZenIV.linux.org.uk> References: <20180711021136.GN30522@ZenIV.linux.org.uk> <20180711022206.12571-1-viro@ZenIV.linux.org.uk> <20180711022206.12571-4-viro@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jul 10, 2018 at 07:35:23PM -0700, Linus Torvalds wrote: > This one looked odd to me. > > Then I saw 5/42, and it made more sense. > > I think the explanation is a bit misleading. Technically correct, but > not *why* you did it. Probably should fold these two together, now that reordering has brought them next to each other (originally there used to be several pieces in between)...