From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nautica.notk.org ([91.121.71.147]:49362 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387811AbeGKNnO (ORCPT ); Wed, 11 Jul 2018 09:43:14 -0400 Date: Wed, 11 Jul 2018 15:38:34 +0200 From: Dominique Martinet To: Matthew Wilcox Cc: v9fs-developer@lists.sourceforge.net, Latchesar Ionkov , Eric Van Hensbergen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Ron Minnich Subject: Re: [V9fs-developer] [PATCH 0/6] 9p: Use IDRs more effectively Message-ID: <20180711133834.GA27521@nautica> References: <20180628132629.3148-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180628132629.3148-1-willy@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Matthew Wilcox wrote on Thu, Jun 28, 2018: > The 9p code doesn't take advantage of the IDR's ability to store > a pointer. We can actually get rid of the p9_idpool abstraction > and the multi-dimensional array of requests. > > I haven't tested these patches, so caveat maintainer. Overall pretty good for something that hadn't even been tested! I'm done with the comments here, the three other patches I didn't comment look good to me. For [PATCH 4/6] 9p: Remove an unnecessary memory barrier, your suggested wording in the comment is good; I've offered to do it if you aren't going to but since you're submitting a second version of the other patchs I suggest you do this one as well. Thanks for the well-needed cleanup, -- Dominique Martinet