From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nautica.notk.org ([91.121.71.147]:59199 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbeGLLkV (ORCPT ); Thu, 12 Jul 2018 07:40:21 -0400 Date: Thu, 12 Jul 2018 13:30:56 +0200 From: Dominique Martinet To: Matthew Wilcox Cc: v9fs-developer@lists.sourceforge.net, Latchesar Ionkov , Eric Van Hensbergen , Ron Minnich , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 3/6] 9p: Replace the fidlist with an IDR Message-ID: <20180712113056.GA23286@nautica> References: <20180711210225.19730-1-willy@infradead.org> <20180711210225.19730-4-willy@infradead.org> <20180712111726.GA17774@nautica> <20180712112333.GA15277@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180712112333.GA15277@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Matthew Wilcox wrote on Thu, Jul 12, 2018: > > Ah, I had missed that you didn't update this memset as you said in reply > > to comment on v1. > > Rather than update the memset, I ... > > > Could you resend just this patch and either initialize fid->fid or use > > kzalloc for the fid allocation? > > > > > + fid->fid = 0; > > Did that instead ;-) > > If I were going to initialise the entire structure to 0, I'd replace > the kmalloc with kzalloc and drop the memset altogether. Oh, I'm blind, sorry! :) > > If you do resend, alignment here was wrong. > > I think this warning from checkpatch is complete bullshit. It's > really none of checkpatch's business how I choose to align function > arguments. > > That said, if you want it to be aligned some particular way, feel free > to adjust the whitespace. I don't care. I would tend to agree that sometimes checkpatch is overzealous, but having worked on projects where code style is all over the place it really feels much more comfortable to have a consistent style everywhere. Thanks for the permission, I'll adjust it (assuming this does end up getting pulled from my branch, but nobody yelled so far) -- Dominique Martinet