From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, "Xu, Wen" <wen.xu@gatech.edu>
Subject: Re: [PATCH] hfsplus: fix NULL dereference in hfsplus_lookup()
Date: Thu, 12 Jul 2018 20:07:51 -0300 [thread overview]
Message-ID: <20180712230750.h55b2sin3a7weqdy@eaf> (raw)
In-Reply-To: <20180712153311.71495c0ea5ba0115414f5301@linux-foundation.org>
On Thu, Jul 12, 2018 at 03:33:11PM -0700, Andrew Morton wrote:
> On Thu, 12 Jul 2018 18:53:47 -0300 Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> wrote:
>
> > Check that the hidden directory is not NULL before using it, instead of
> > after.
> >
>
> Under what circumstances does the crash happen? Mount of a corrupted fs?
No, when looking up corrupted catalog data (dentry) on a filesystem with
no metadata directory (this could only ever happen on a read-only mount).
Wen Xu sent the replication steps in detail to the fsdevel list, here is
a link:
https://bugzilla.kernel.org/show_bug.cgi?id=200297
I did not explain this because I think the diff makes it clear that there
is a bug at least.
next prev parent reply other threads:[~2018-07-12 23:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 21:53 [PATCH] hfsplus: fix NULL dereference in hfsplus_lookup() Ernesto A. Fernández
2018-07-12 22:55 ` Viacheslav Dubeyko
2018-08-21 23:05 ` Andrew Morton
2018-08-22 18:46 ` Ernesto A. Fernández
2018-08-22 20:18 ` Viacheslav Dubeyko
2018-08-22 21:38 ` Ernesto A. Fernández
[not found] ` <20180712153311.71495c0ea5ba0115414f5301@linux-foundation.org>
2018-07-12 23:07 ` Ernesto A. Fernández [this message]
[not found] ` <20180712161907.c93f4e70e5d406fd3d2d373e@linux-foundation.org>
2018-07-12 23:23 ` Ernesto A. Fernández
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712230750.h55b2sin3a7weqdy@eaf \
--to=ernesto.mnd.fernandez@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wen.xu@gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).