linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] fs/coda: potential buffer overflow in coda_psdev_write()
Date: Fri, 13 Jul 2018 15:08:13 -0400	[thread overview]
Message-ID: <20180713190812.e4rhbaquh2iiktvj@cs.cmu.edu> (raw)
In-Reply-To: <20180713190503.eei3axzltm7pt4aa@mwanda>

On Fri, Jul 13, 2018 at 10:05:03PM +0300, Dan Carpenter wrote:
> > The proper fix should be to check that we received at least enough data
> > to fully read the received downcall message based on the opcode in the
> > received message header and log/return an error if it doesn't match.
> 
> I just wanted to solve the memory corruption without breaking user
> space.  What you're proposing sounds more complicated and probably
> someone should test it.  Can you fix it and give me a Reported-by tag?

Should not be too hard and I am in the best position to test it, so yes
I will do that.

Jan

  reply	other threads:[~2018-07-13 19:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12 12:32 [PATCH] fs/coda: potential buffer overflow in coda_psdev_write() Dan Carpenter
2018-07-12 15:31 ` Jan Harkes
2018-07-12 15:50   ` Dan Carpenter
     [not found] ` <20180713151017.lxbv4eljvd6olziq@kili.mountain>
     [not found]   ` <20180713161630.olrwa2n2tnpqbmlt@cs.cmu.edu>
2018-07-13 19:05     ` [PATCH v2] " Dan Carpenter
2018-07-13 19:08       ` Jan Harkes [this message]
2018-07-14  2:24       ` [PATCH v3] " Jan Harkes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180713190812.e4rhbaquh2iiktvj@cs.cmu.edu \
    --to=jaharkes@cs.cmu.edu \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).