From: kbuild test robot <lkp@intel.com>
To: Waiman Long <longman@redhat.com>
Cc: kbuild-all@01.org, Alexander Viro <viro@zeniv.linux.org.uk>,
Jonathan Corbet <corbet@lwn.net>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, linux-doc@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Miklos Szeredi <mszeredi@redhat.com>,
Matthew Wilcox <willy@infradead.org>,
Larry Woodman <lwoodman@redhat.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
"Wangkai (Kevin C)" <wangkai86@huawei.com>,
Michal Hocko <mhocko@kernel.org>,
Waiman Long <longman@redhat.com>
Subject: Re: [PATCH v7 4/6] fs/dcache: Print negative dentry warning every min until turned off by user
Date: Tue, 17 Jul 2018 09:24:44 +0800 [thread overview]
Message-ID: <20180717012444.GB10593@intel.com> (raw)
In-Reply-To: <1531413965-5401-5-git-send-email-longman@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 4995 bytes --]
Hi Waiman,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc4]
[cannot apply to next-20180713]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Waiman-Long/fs-dcache-Track-report-number-of-negative-dentries/20180714-161258
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
:::::: branch date: 45 minutes ago
:::::: commit date: 45 minutes ago
Note: the linux-review/Waiman-Long/fs-dcache-Track-report-number-of-negative-dentries/20180714-161258 HEAD ca68ee513a450445b269248c2859302c8931a294 builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
fs/dcache.c: In function 'neg_dentry_inc_slowpath':
>> fs/dcache.c:355:8: error: implicit declaration of function 'get_nr_dentry_neg'; did you mean 'neg_dentry_dec'? [-Werror=implicit-function-declaration]
cnt = get_nr_dentry_neg();
^~~~~~~~~~~~~~~~~
neg_dentry_dec
cc1: some warnings being treated as errors
# https://github.com/0day-ci/linux/commit/2aa8bf4658af0dbc07ae9ea07d04937a347e3ef4
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 2aa8bf4658af0dbc07ae9ea07d04937a347e3ef4
vim +355 fs/dcache.c
bcc9ba8b Waiman Long 2018-07-12 310
bcc9ba8b Waiman Long 2018-07-12 311 static noinline void neg_dentry_inc_slowpath(struct dentry *dentry)
bcc9ba8b Waiman Long 2018-07-12 312 {
bcc9ba8b Waiman Long 2018-07-12 313 long cnt = 0, *pcnt;
2aa8bf46 Waiman Long 2018-07-12 314 unsigned long current_time;
bcc9ba8b Waiman Long 2018-07-12 315
bcc9ba8b Waiman Long 2018-07-12 316 /*
bcc9ba8b Waiman Long 2018-07-12 317 * Try to move some negative dentry quota from the global free
bcc9ba8b Waiman Long 2018-07-12 318 * pool to the percpu count to allow more negative dentries to
bcc9ba8b Waiman Long 2018-07-12 319 * be added to the LRU.
bcc9ba8b Waiman Long 2018-07-12 320 */
bcc9ba8b Waiman Long 2018-07-12 321 pcnt = get_cpu_ptr(&nr_dentry_neg);
bcc9ba8b Waiman Long 2018-07-12 322 if ((READ_ONCE(ndblk.nfree) > 0) &&
bcc9ba8b Waiman Long 2018-07-12 323 (*pcnt > neg_dentry_percpu_limit)) {
bcc9ba8b Waiman Long 2018-07-12 324 cnt = __neg_dentry_nfree_dec(*pcnt - neg_dentry_percpu_limit);
bcc9ba8b Waiman Long 2018-07-12 325 *pcnt -= cnt;
bcc9ba8b Waiman Long 2018-07-12 326 }
bcc9ba8b Waiman Long 2018-07-12 327 put_cpu_ptr(&nr_dentry_neg);
bcc9ba8b Waiman Long 2018-07-12 328
2aa8bf46 Waiman Long 2018-07-12 329 if (cnt)
2aa8bf46 Waiman Long 2018-07-12 330 goto out;
2aa8bf46 Waiman Long 2018-07-12 331
bcc9ba8b Waiman Long 2018-07-12 332 /*
2aa8bf46 Waiman Long 2018-07-12 333 * Put out a warning every minute or so if there are just too many
2aa8bf46 Waiman Long 2018-07-12 334 * negative dentries.
bcc9ba8b Waiman Long 2018-07-12 335 */
2aa8bf46 Waiman Long 2018-07-12 336 current_time = jiffies;
bcc9ba8b Waiman Long 2018-07-12 337
2aa8bf46 Waiman Long 2018-07-12 338 if (current_time < ndblk.warn_jiffies + NEG_WARN_PERIOD)
2aa8bf46 Waiman Long 2018-07-12 339 goto out;
2aa8bf46 Waiman Long 2018-07-12 340 /*
2aa8bf46 Waiman Long 2018-07-12 341 * Update the time in ndblk.warn_jiffies and print a warning
2aa8bf46 Waiman Long 2018-07-12 342 * if time update is successful.
2aa8bf46 Waiman Long 2018-07-12 343 */
2aa8bf46 Waiman Long 2018-07-12 344 raw_spin_lock(&ndblk.nfree_lock);
2aa8bf46 Waiman Long 2018-07-12 345 if (current_time < ndblk.warn_jiffies + NEG_WARN_PERIOD) {
2aa8bf46 Waiman Long 2018-07-12 346 raw_spin_unlock(&ndblk.nfree_lock);
2aa8bf46 Waiman Long 2018-07-12 347 goto out;
2aa8bf46 Waiman Long 2018-07-12 348 }
2aa8bf46 Waiman Long 2018-07-12 349 ndblk.warn_jiffies = current_time;
2aa8bf46 Waiman Long 2018-07-12 350 raw_spin_unlock(&ndblk.nfree_lock);
2aa8bf46 Waiman Long 2018-07-12 351
2aa8bf46 Waiman Long 2018-07-12 352 /*
2aa8bf46 Waiman Long 2018-07-12 353 * Get the current negative dentry count & print a warning.
2aa8bf46 Waiman Long 2018-07-12 354 */
2aa8bf46 Waiman Long 2018-07-12 @355 cnt = get_nr_dentry_neg();
2aa8bf46 Waiman Long 2018-07-12 356 pr_warn("Warning: Too many negative dentries (%ld). "
2aa8bf46 Waiman Long 2018-07-12 357 "This warning can be disabled by writing 0 to \"fs/neg-dentry-limit\" or increasing the limit.\n",
2aa8bf46 Waiman Long 2018-07-12 358 cnt);
2aa8bf46 Waiman Long 2018-07-12 359 out:
2aa8bf46 Waiman Long 2018-07-12 360 return;
bcc9ba8b Waiman Long 2018-07-12 361 }
bcc9ba8b Waiman Long 2018-07-12 362
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 6369 bytes --]
next prev parent reply other threads:[~2018-07-17 1:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:45 [PATCH v7 0/6] fs/dcache: Track & limit # of negative dentries Waiman Long
2018-07-12 16:46 ` [PATCH v7 1/6] fs/dcache: Track & report number " Waiman Long
2018-07-12 16:46 ` [PATCH v7 2/6] fs/dcache: Add negative dentries to LRU head initially Waiman Long
2018-07-12 16:46 ` [PATCH v7 3/6] fs/dcache: Add sysctl parameter neg-dentry-limit as a soft limit on negative dentries Waiman Long
2018-07-12 16:56 ` Matthew Wilcox
2018-07-12 17:04 ` Waiman Long
2018-07-12 16:46 ` [PATCH v7 4/6] fs/dcache: Print negative dentry warning every min until turned off by user Waiman Long
2018-07-17 1:24 ` kbuild test robot [this message]
2018-07-12 16:46 ` [PATCH v7 5/6] fs/dcache: Allow optional enforcement of negative dentry limit Waiman Long
2018-07-12 16:46 ` [PATCH v7 6/6] fs/dcache: Allow deconfiguration of negative dentry code to reduce kernel size Waiman Long
2018-07-17 1:25 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717012444.GB10593@intel.com \
--to=lkp@intel.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jack@suse.cz \
--cc=kbuild-all@01.org \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=lwoodman@redhat.com \
--cc=mcgrof@kernel.org \
--cc=mhocko@kernel.org \
--cc=mingo@kernel.org \
--cc=mszeredi@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkai86@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).