From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:51306 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728889AbeGQNny (ORCPT ); Tue, 17 Jul 2018 09:43:54 -0400 Date: Tue, 17 Jul 2018 15:13:49 +0200 From: Christoph Hellwig To: Shan Hai Cc: hch@lst.de, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/1] iomap: simplify header file include guard macro definition Message-ID: <20180717131349.GB13582@lst.de> References: <1531724836-7944-1-git-send-email-shan.hai@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1531724836-7944-1-git-send-email-shan.hai@oracle.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote: > The simple definition of a macro is enough for the include guard, it's not > necessary to assign a value to it, so remove the assignment. > > Signed-off-by: Shan Hai And what is the exact benefit of changing this?