From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:56050 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731497AbeGQOUj (ORCPT ); Tue, 17 Jul 2018 10:20:39 -0400 Date: Tue, 17 Jul 2018 06:47:50 -0700 From: Matthew Wilcox To: Christoph Hellwig Cc: Shan Hai , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/1] iomap: simplify header file include guard macro definition Message-ID: <20180717134750.GA30644@bombadil.infradead.org> References: <1531724836-7944-1-git-send-email-shan.hai@oracle.com> <20180717131349.GB13582@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180717131349.GB13582@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Jul 17, 2018 at 03:13:49PM +0200, Christoph Hellwig wrote: > On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote: > > The simple definition of a macro is enough for the include guard, it's not > > necessary to assign a value to it, so remove the assignment. > > > > Signed-off-by: Shan Hai > > And what is the exact benefit of changing this? doesn't seem worthwhile to me either. If anything's going to change, it should probably be _LINUX_IOMAP_H (insofaras we have a standard for include guards, a single _ seems to be preferred)