From: Paul Burton <paul.burton@mips.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-fsdevel@vger.kernel.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] MIPS: DSP ASE regset support
Date: Thu, 19 Jul 2018 13:56:30 -0700 [thread overview]
Message-ID: <20180719205630.osfdzk7gqv4djvqc@pburton-laptop> (raw)
In-Reply-To: <alpine.DEB.2.00.1804301557320.11756@tp.orcam.me.uk>
Hi Maciej,
On Tue, May 15, 2018 at 11:32:11PM +0100, Maciej W. Rozycki wrote:
> For years, quite oddly, we have been missing DSP ASE register state from
> core files. These days regsets are used to define what goes into a core
> file, so here's a change adding one.
>
> As a side effect ptrace(2) can now also access this regset, however no
> complementing client implementation has been made. Eventually that'll
> have to change though so that DSP ASE registers can be correctly accessed
> in n32 processes, which suffer from ptrace(2) 32-bit data types truncating
> contents exchanged by PTRACE_PEEKUSR and PTRACE_POKEUSR requests with
> 64-bit registers and no means defined to access partial registers via this
> API.
>
> In the course of this implementation I came across two bugs affecting the
> area being updated and hence this has become a small patch series with the
> audience wider than originally expected.
>
> See individual commit descriptions for the details of changes made.
>
> NB there is no strict functional dependency between 1/3 and 2/3-3/3, so
> the order of commits does not have to be preserved as far as these two
> subsets are concerned. However 3/3 does trigger the problem addressed
> with 1/3 (and gracefully handles it), hence the grouping in a series.
>
> Please apply.
Thanks - applied to mips-next for 4.19, though I removed the stable tags
on patches 1/3 & 3/3 & it's worth noting that the ELF note numbers are
changed to from 0x70X to 0x80X, since 0x700 has been used already.
If you really care about a stable backport for 3/3 let's talk, but I'm
doubtful as to its use when we've been missing this for so long.
Paul
next prev parent reply other threads:[~2018-07-19 21:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 22:32 [PATCH 0/3] MIPS: DSP ASE regset support Maciej W. Rozycki
2018-05-15 22:32 ` [PATCH 1/3] binfmt_elf: Respect error return from `regset->active' Maciej W. Rozycki
2018-06-29 17:13 ` Paul Burton
2018-07-16 5:44 ` Maciej W. Rozycki
2018-05-15 22:33 ` [PATCH 2/3] MIPS: Correct the 64-bit DSP accumulator register size Maciej W. Rozycki
2018-05-15 22:34 ` [PATCH 3/3] MIPS: Add DSP ASE regset support Maciej W. Rozycki
2018-07-19 20:56 ` Paul Burton [this message]
2018-07-19 21:25 ` [PATCH 0/3] MIPS: " Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719205630.osfdzk7gqv4djvqc@pburton-laptop \
--to=paul.burton@mips.com \
--cc=jhogan@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@mips.com \
--cc=ralf@linux-mips.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).