archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <>
To: Souptick Joarder <>
Cc: "Darrick J. Wong" <>,
	Christoph Hellwig <>,
	Andrew Morton <>,
	Alexander Viro <>, Jan Kara <>,
	Dave Chinner <>, Theodore Ts'o <>,
	Bob Peterson <>,
	Greg Kroah-Hartman <>,
	linux-fsdevel <>,
	LKML <>,
	Andreas Gruenbacher <>
Subject: Re: [PATCH] fs: iomap: Change return type to vm_fault_t
Date: Fri, 20 Jul 2018 12:36:55 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Jul 20, 2018 at 12:25:26PM +0530, Souptick Joarder wrote:
> At this point we are almost done with vm_fault_t migration in all drivers/fs
> except 3 patches and all the changes will be available in 4.19-rc1.

I think there's a little more than that left to do.  I'm looking at
linux-next 20180720.

Documentation/filesystems/Locking:      int (*fault)(struct vm_area_struct*, struct vm_fault *);
arch/s390/kernel/vdso.c-static int vdso_fault(const struct vm_special_mapping *sm,
arch/s390/kernel/vdso.c:                      struct vm_area_struct *vma, struct vm_fault *vmf)
arch/x86/entry/vdso/vma.c-static int vdso_fault(const struct vm_special_mapping *sm,
arch/x86/entry/vdso/vma.c:                    struct vm_area_struct *vma, struct vm_fault *vmf)
drivers/dax/device.c:static int __dev_dax_pte_fault(struct dev_dax *dev_dax, struct vm_fault *vmf)
drivers/gpu/drm/armada/armada_gem.c:static int armada_gem_vm_fault(struct vm_fault *vmf)
drivers/gpu/drm/etnaviv/etnaviv_gem.c:int etnaviv_gem_fault(struct vm_fault *vmf)
drivers/gpu/drm/msm/msm_gem.c:int msm_gem_fault(struct vm_fault *vmf)
drivers/gpu/drm/virtio/virtgpu_ttm.c:static int virtio_gpu_ttm_fault(struct vm_fault *vmf)
drivers/gpu/drm/vkms/vkms_gem.c:int vkms_gem_fault(struct vm_fault *vmf)
fs/buffer.c:int block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
fs/ceph/addr.c:static int ceph_filemap_fault(struct vm_fault *vmf)
fs/ext4/inode.c:int ext4_page_mkwrite(struct vm_fault *vmf)
fs/iomap.c:int iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops)
fs/userfaultfd.c:int handle_userfault(struct vm_fault *vmf, unsigned long reason)
mm/filemap.c:int filemap_page_mkwrite(struct vm_fault *vmf)
mm/huge_memory.c:static int __do_huge_pmd_anonymous_page(struct vm_fault *vmf, struct page *page,
mm/memory.c:static int do_page_mkwrite(struct vm_fault *vmf)

That's about 18 files left to handle.  I know some of these are still
in flight, but others I don't think I've seen patches for.

To get to the end-goal of eliminating vm_insert_* (leaving only
vmf_insert_*), there are some other tricky customers to satisfy.

remap_vmalloc_range_partial() is one; fortunately neither of the two
callers care about the errno; they choose their own errno to return if
an error happens, so we can change that one too.

I don't have time to go through the rest now ;-)

  reply	other threads:[~2018-07-20 20:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-02 15:43 [PATCH] fs: iomap: Change return type to vm_fault_t Souptick Joarder
2018-07-02 17:52 ` Andreas Gruenbacher
2018-07-03 21:39   ` Darrick J. Wong
2018-07-03 21:52     ` Andreas Gruenbacher
2018-07-20  5:01       ` Souptick Joarder
2018-07-20  6:09         ` Darrick J. Wong
2018-07-20  6:55           ` Souptick Joarder
2018-07-20 19:36             ` Matthew Wilcox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-08-27 17:20 Souptick Joarder
2018-04-14 20:02 Souptick Joarder
2018-05-14 18:15 ` Souptick Joarder
2018-05-15  7:10   ` Christoph Hellwig
2018-05-15  8:00     ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).