From: Huaisheng Ye <yehs2007@zoho.com>
To: linux-nvdimm@lists.01.org, dan.j.williams@intel.com
Cc: ross.zwisler@linux.intel.com, willy@infradead.org,
vishal.l.verma@intel.com, dave.jiang@intel.com,
schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com,
viro@zeniv.linux.org.uk, martin.petersen@oracle.com,
axboe@kernel.dk, gregkh@linuxfoundation.org,
bart.vanassche@wdc.com, jack@suse.cz, agk@redhat.com,
snitzer@redhat.com, keescook@chromium.org, dm-devel@redhat.com,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
linux-fsdevel@vger.kernel.org, colyli@suse.de,
chengnt@lenovo.com, Huaisheng Ye <yehs1@lenovo.com>
Subject: [PATCH v3 4/6] dax/super: Do not request a pointer kaddr when not required
Date: Mon, 30 Jul 2018 15:15:46 +0800 [thread overview]
Message-ID: <20180730071548.9172-5-yehs2007@zoho.com> (raw)
In-Reply-To: <20180730071548.9172-1-yehs2007@zoho.com>
From: Huaisheng Ye <yehs1@lenovo.com>
Function __bdev_dax_supported doesn't need to get local pointer kaddr
from direct_access. Using NULL instead of having to pass in a useless
local pointer that caller then just throw away.
Signed-off-by: Huaisheng Ye <yehs1@lenovo.com>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
drivers/dax/super.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 45276ab..6e928f3 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -89,7 +89,6 @@ bool __bdev_dax_supported(struct block_device *bdev, int blocksize)
struct request_queue *q;
pgoff_t pgoff;
int err, id;
- void *kaddr;
pfn_t pfn;
long len;
char buf[BDEVNAME_SIZE];
@@ -122,7 +121,7 @@ bool __bdev_dax_supported(struct block_device *bdev, int blocksize)
}
id = dax_read_lock();
- len = dax_direct_access(dax_dev, pgoff, 1, &kaddr, &pfn);
+ len = dax_direct_access(dax_dev, pgoff, 1, NULL, &pfn);
dax_read_unlock(id);
put_dax(dax_dev);
--
1.8.3.1
next prev parent reply other threads:[~2018-07-30 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:15 [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 1/6] libnvdimm, pmem: " Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 2/6] s390, dcssblk: " Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 3/6] tools/testing/nvdimm: " Huaisheng Ye
2018-07-30 7:15 ` Huaisheng Ye [this message]
2018-07-30 7:15 ` [PATCH v3 5/6] md/dm-writecache: Don't request pointer dummy_addr when not required Huaisheng Ye
2018-07-30 7:15 ` [PATCH v3 6/6] filesystem-dax: Do not request kaddr and pfn " Huaisheng Ye
2018-07-30 7:30 ` [External] [PATCH v3 0/6] kaddr and pfn can be NULL to ->direct_access() Huaisheng HS1 Ye
2018-07-31 15:35 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730071548.9172-5-yehs2007@zoho.com \
--to=yehs2007@zoho.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=bart.vanassche@wdc.com \
--cc=chengnt@lenovo.com \
--cc=colyli@suse.de \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dm-devel@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jack@suse.cz \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-s390@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ross.zwisler@linux.intel.com \
--cc=schwidefsky@de.ibm.com \
--cc=snitzer@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=willy@infradead.org \
--cc=yehs1@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).