linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Christian Brauner <christian@brauner.io>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, arve@android.com,
	tkjos@android.com, maco@android.com, rlove@google.com,
	ben@decadent.org.uk
Subject: Re: [PATCH 3/4] file: export get_files_struct()
Date: Mon, 30 Jul 2018 09:32:56 -0700	[thread overview]
Message-ID: <20180730163256.GC27761@infradead.org> (raw)
In-Reply-To: <20180730143710.14413-4-christian@brauner.io>

On Mon, Jul 30, 2018 at 04:37:09PM +0200, Christian Brauner wrote:
> The Android binder driver will be turned into a module. Since it uses
> get_files_struct() we need to export this function.

Hell no.  Please explain why so that we can find a better way.

  reply	other threads:[~2018-07-30 16:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 14:37 [RFC PATCH 0/4] file: export functions for binder module Christian Brauner
2018-07-30 14:37 ` [PATCH 1/4] file: export __alloc_fd() Christian Brauner
2018-07-30 16:31   ` Christoph Hellwig
2018-07-30 20:36     ` Matthew Wilcox
2018-07-30 21:43       ` Al Viro
2018-07-31  8:44       ` Martijn Coenen
2018-07-31 10:07         ` Christian Brauner
2018-07-31 10:37           ` Martijn Coenen
2018-07-30 14:37 ` [PATCH 2/4] file: export __fd_install() Christian Brauner
2018-07-30 16:32   ` Christoph Hellwig
2018-07-30 14:37 ` [PATCH 3/4] file: export get_files_struct() Christian Brauner
2018-07-30 16:32   ` Christoph Hellwig [this message]
2018-07-30 14:37 ` [PATCH 4/4] file: export put_files_struct() Christian Brauner
2018-07-30 16:33   ` Christoph Hellwig
2018-07-30 16:34 ` [RFC PATCH 0/4] file: export functions for binder module Christoph Hellwig
2018-07-30 20:12   ` Christian Brauner
2018-07-30 20:19     ` Matthew Wilcox
2018-07-30 20:28       ` Christian Brauner
2018-07-30 21:41         ` Al Viro
2018-08-02 13:31           ` Christian Brauner
2018-07-31 14:27   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180730163256.GC27761@infradead.org \
    --to=hch@infradead.org \
    --cc=arve@android.com \
    --cc=ben@decadent.org.uk \
    --cc=christian@brauner.io \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maco@android.com \
    --cc=rlove@google.com \
    --cc=tkjos@android.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).