From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:38938 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732000AbeGaOIJ (ORCPT ); Tue, 31 Jul 2018 10:08:09 -0400 Date: Tue, 31 Jul 2018 14:28:01 +0200 From: Pavel Machek To: Matthew Wilcox Cc: David Howells , "Theodore Y. Ts'o" , Linus Torvalds , Al Viro , linux-fsdevel , Linux Kernel Mailing List Subject: Re: [PATCH 36/38] vfs: Add a sample program for the new mount API [ver #10] Message-ID: <20180731122801.GA14972@amd> References: <20180730183847.GB5544@bombadil.infradead.org> <20180730194938.GA12962@bombadil.infradead.org> <20180730210209.GY21725@thunk.org> <20180730235849.GA19692@bombadil.infradead.org> <20180731005802.GB21725@thunk.org> <18974.1533031913@warthog.procyon.org.uk> <20180731113422.GA22939@amd> <20180731120752.GA23378@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="BOKacYhQ+x31HxR3" Content-Disposition: inline In-Reply-To: <20180731120752.GA23378@bombadil.infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: --BOKacYhQ+x31HxR3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2018-07-31 05:07:52, Matthew Wilcox wrote: > On Tue, Jul 31, 2018 at 01:34:22PM +0200, Pavel Machek wrote: > > On Tue 2018-07-31 11:11:53, David Howells wrote: > > > Pavel Machek wrote: > > > > Proposal is "message %s foo %s\0param 1\0param2\0", only strings > > > > allowed. > > >=20 > > > I think that's too strict and you will need to allow integer values, = IP > > > addresses and possibly other things also. It could certainly have a = limited > > > set (e.g. no kernel pointers). > >=20 > > I'd always use strings at kernel->user interface. Yes, we should > > support integers and IP addresses in kernel, but I'd convert them to > > strings before passing them to userspace. >=20 > Then you haven't solved the translation problem at all; you've just made > the in-kernel implementation harder. One example from the gettext docs: >=20 > In Polish we use e.g. plik (file) this way: >=20 > 1 plik > 2,3,4 pliki > 5-21 plik=F3w > 22-24 pliki > 25-31 plik=F3w >=20 > Your proposal means that userspace needs to detect "%s file", determine > if the corresponding string consists of ^[0-9]*$, then parse the string > to figure out which of the plik* words is the correct one to use. Have you actually used computer set in slavic language? Receiving "5 soubor(u) zkopirovano" is still preferable to message in english. > In my preferred solution of just sending the damned english string, > it's no more complex to regex match the string for "[0-9]* file", and > choose the appropriate plik* translation. Regexes do not work in presence of arbitrary strings in the message. If we had a way to tell start / end of string inserted in the message, yes, the problem would be solved. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --BOKacYhQ+x31HxR3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAltgVdEACgkQMOfwapXb+vKmQQCfVXU6GDtXvZK7L3EqOME4lqZQ h4IAn0fHutBDMGTB1mSw3+9wRrKTr6yc =OJPq -----END PGP SIGNATURE----- --BOKacYhQ+x31HxR3--