From: Andrei Vagin <email@example.com>
To: David Howells <firstname.lastname@example.org>
Cc: Andrei Vagin <email@example.com>,
firstname.lastname@example.org, Andrei Vagin <email@example.com>
Subject: Re: [PATCH dhowells/mount-context] fs: don't call fs_context->free() from fsmount()
Date: Tue, 31 Jul 2018 15:48:08 -0700 [thread overview]
Message-ID: <20180731224807.GA8037@outlook.office365.com> (raw)
On Tue, Jul 31, 2018 at 09:56:45PM +0100, David Howells wrote:
> Andrei Vagin <firstname.lastname@example.org> wrote:
> > > I can do this two ways: (1) stick a flag in the context that says if
> > > ->free() needs calling, (2) make all the ->free() routines aware that they
> > > may see the reset state. I think (1) is less error prone.
> > Does it mean that fc->fs_type->init_fs_context() should not be called
> > contexts which are created from fspick()?
> No. I've put a flag in the context that is set when ->init_fs_context() is
> called and cleared when ->free() is called. ->free() isn't called in the put
> routine if the flag isn't set.
> /* We've done the mount bit - now move the file context into
> * more or less the same state as if we'd done an fspick().
According to this comment, a context after fsmount() should be in
the same state as after fspick().
In fsmount(), we call ->free() which is oposite to init_fs_context(). If
we want to have "more or less the same state" and want to call
fs_context->free() in fsmount(), this means that we should not call
fc->fs_type->init_fs_context() in fspick()... Where am I wrong?
next prev parent reply other threads:[~2018-08-01 0:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 7:29 [PATCH dhowells/mount-context] fs: don't call fs_context->free() from fsmount() Andrei Vagin
2018-07-31 8:52 ` David Howells
2018-07-31 17:34 ` Andrei Vagin
2018-07-31 20:56 ` David Howells
2018-07-31 22:48 ` Andrei Vagin [this message]
2018-08-01 0:42 ` David Howells
2018-08-01 5:53 ` Andrei Vagin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).