From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:40353 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbeHBRzW (ORCPT ); Thu, 2 Aug 2018 13:55:22 -0400 Date: Thu, 2 Aug 2018 18:08:16 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Avi Kivity , linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] aio: implement IOCB_CMD_POLL Message-ID: <20180802160816.GA9447@lst.de> References: <20180730071544.23998-1-hch@lst.de> <20180730071544.23998-4-hch@lst.de> <20180802002121.GU30522@ZenIV.linux.org.uk> <20180802092234.GA13797@lst.de> <20180802160032.GY30522@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180802160032.GY30522@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Aug 02, 2018 at 05:00:32PM +0100, Al Viro wrote: > BTW, what happens if we insert into one queue and immediately get > woken up, even before the damn thing gets to the end of ->poll(), > which proceeds to call poll_wait() again (on another queue)? > AFAICS, apt.error will be set by the second callback and completely > ignored. And so will the return value of ->poll()... > > Sigh... Analysis of that thing is bloody painful, mostly because > it's hard to describe the state... That's the problem with the ->poll interface. We call it, then have magic happen underneath where it might or might not get added to one (or more if we didn't exclude that) waitqueues, and might have actually been worken before return. I can't really think of a good way to do that entirely sanely. Best I can think of is to only allow using file ops that do keyed wakeups and rely on the keyed wakeups alone. I've started coming up with a version of that, but it won't be until tomorrow at least that I can post it.