From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 7 Aug 2018 09:27:02 +0200 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Al Viro , Avi Kivity , linux-aio@kvack.org, linux-fsdevel , Linux Kernel Mailing List Subject: Re: aio poll V22 (aka 2.0) Message-ID: <20180807072702.GB678@lst.de> References: <20180806083058.14724-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Mon, Aug 06, 2018 at 09:49:24AM -0700, Linus Torvalds wrote: > I'm not seeing what's painful for this. Looking at the patches, this > is *much* more straightforward than your previous patch, > > It adds refcounting to aio_iocb, but that's *much* better than messing > up every other subsystem. > > Or is there some follow-up patches that are pending but you didn't > post that are the painful part? Because the diffstat says that this > second version is *way* less painful, at about 200 lines of code in a > couple of files, mostly aio, vs ~700 lines of changes all over the > place, together with a performance regression. It requires additional lock roundtrips and very strange life time rules. But we've already established that our preference here are different, so I'm not surprised by your different view.