From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:47608 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1728811AbeHOPnZ (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 15 Aug 2018 11:43:25 -0400
Date: Wed, 15 Aug 2018 13:51:14 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Beulich <JBeulich@suse.com>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Juergen Gross <jgross@suse.com>,
        xen-devel <xen-devel@lists.xenproject.org>,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH RESEND] compat-ioctl/Xen: support at least some IOCTLs of
 evtchn and privcmd
Message-ID: <20180815125114.GV6515@ZenIV.linux.org.uk>
References: <5B30C6E202000078001CD724@prv1-mh.provo.novell.com>
 <5B73C5D402000078001DE189@prv1-mh.provo.novell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5B73C5D402000078001DE189@prv1-mh.provo.novell.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Aug 15, 2018 at 12:19:00AM -0600, Jan Beulich wrote:
> While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP
> require more work), it at least allows some simple operations (like
> "xl dmesg") which have always been available on XenoLinux to work again
> with a 64-bit kernel underneath a 32-bit distro.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Acked-by: Juergen Gross <jgross@suse.com>


Nacked-by: Al Viro <viro@zeniv.linux.org.uk>

	This belongs in drivers/xen/privcmd.c, not in fs/compat_ioctl.c
*ANY* single-driver ioctl definitely should be handled by ->compat_ioctl()
method and any patches dumping such stuff into fs/compat_ioctl.c will be
rejected.