From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <email@example.com>,
Boris Ostrovsky <firstname.lastname@example.org>,
Juergen Gross <email@example.com>,
Subject: Re: [PATCH RESEND] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd
Date: Wed, 15 Aug 2018 14:27:31 +0100 [thread overview]
Message-ID: <20180815132730.GW6515@ZenIV.linux.org.uk> (raw)
On Wed, Aug 15, 2018 at 07:16:43AM -0600, Jan Beulich wrote:
> >>> On 15.08.18 at 14:51, <viro@ZenIV.linux.org.uk> wrote:
> > On Wed, Aug 15, 2018 at 12:19:00AM -0600, Jan Beulich wrote:
> >> While this is only a start (IOCTL_PRIVCMD_MMAP* and IOCTL_PRIVCMD_DM_OP
> >> require more work), it at least allows some simple operations (like
> >> "xl dmesg") which have always been available on XenoLinux to work again
> >> with a 64-bit kernel underneath a 32-bit distro.
> >> Signed-off-by: Jan Beulich <firstname.lastname@example.org>
> >> Acked-by: Juergen Gross <email@example.com>
> > Nacked-by: Al Viro <firstname.lastname@example.org>
> > This belongs in drivers/xen/privcmd.c, not in fs/compat_ioctl.c
> > *ANY* single-driver ioctl definitely should be handled by ->compat_ioctl()
> > method and any patches dumping such stuff into fs/compat_ioctl.c will be
> > rejected.
> Okay, I'll see about doing this; I have to admit I was unaware of
> ->compat_ioctl()'s existence. It would be rather helpful if the header
> of compat_ioctl.c indicated what you say. Without that, I've simply
> gone by the observation that there are things in the file which
> according to what you say shouldn't be there, and I've then wrongly
> implied adding the Xen stuff here would be fine.
Originally fs/compat_ioctl.c was a result of merger between several such
beasts in arch/*; it's *old* - well before ->compat_ioctl() introduction.
If you check the history of that thing, you'll see crap getting removed
over the years. Sometimes the things sneak in, but generally it keeps
The only stuff that might belong there is widely-implemented ioctls.
Anything that is natively handled in a couple of ->ioctl() instances
should be getting ->compat_ioctl() instance to go with that one.
And yes, big fat warning along the lines of "don't dump here" is
probably a good idea...
prev parent reply other threads:[~2018-08-15 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5B30C6E202000078001CD724@prv1-mh.provo.novell.com>
2018-08-15 6:19 ` [PATCH RESEND] compat-ioctl/Xen: support at least some IOCTLs of evtchn and privcmd Jan Beulich
2018-08-15 12:41 ` Christoph Hellwig
2018-08-15 12:51 ` Al Viro
2018-08-15 13:16 ` Jan Beulich
2018-08-15 13:27 ` Al Viro [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).