From: Kent Overstreet <kent.overstreet@gmail.com>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk
Subject: Re: [PATCH 0/2] generic_file_buffered_read improvements
Date: Thu, 16 Aug 2018 06:05:31 -0400 [thread overview]
Message-ID: <20180816100531.GC24640@kmo-pixel> (raw)
In-Reply-To: <20180816075740.2gazls4q46y5rmuq@odin.usersys.redhat.com>
On Thu, Aug 16, 2018 at 09:57:40AM +0200, Carlos Maiolino wrote:
> On Wed, Aug 15, 2018 at 07:26:30PM -0400, Kent Overstreet wrote:
> > Small patch series to
> > - firstly, refactor generic_file_buffered_read enough that it can be modified
> > in more interesting ways without going insane, and then
> >
> > - secondly, change it to use find_get_pages_contig() to batch up the page
> > operations, and then copy data to userspace in a separate loop that touches
> > no other shared cachelines.
> >
> > I've been seeing profiles where the radix tree lookups in the buffered read path
> > are a shockingly large portion of the profile (around 25%, if memory serves) -
> > that's what this patch series is addressing. I've benchmarked small block reads
> > as well, performance there is unaffected or slightly improved (it's within the
> > margin of error).
> >
>
> /me didn't review the patches, but...
>
> Could you share how you benchmarked it? Despite the fact I'm curious about it,
> it's going to be interesting the 'proof' of such improvement.
I tried coming up with a microbenchmark and gave up because it was getting too
ridiculous - you need something _modifying_ the page cache radix tree for the
contention to show up. That's usually going to be page reclaim, which means you
can't just populate the page cache and run your benchmark, you have to be
reading stuff in and evicting stuff. Which means you need waaay higher end IO
devices than what I have at home for it to show up.
But it's pretty obvious from the profiles of the affected workloads what's going
on.
next prev parent reply other threads:[~2018-08-16 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 23:26 [PATCH 0/2] generic_file_buffered_read improvements Kent Overstreet
2018-08-15 23:26 ` [PATCH 1/2] fs: Break generic_file_buffered_read up into multiple functions Kent Overstreet
2018-08-15 23:26 ` [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig Kent Overstreet
2018-08-16 14:56 ` kbuild test robot
2018-08-16 7:57 ` [PATCH 0/2] generic_file_buffered_read improvements Carlos Maiolino
2018-08-16 10:05 ` Kent Overstreet [this message]
2018-08-17 22:42 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180816100531.GC24640@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=cmaiolino@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).