From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:35449 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389123AbeHPQQH (ORCPT ); Thu, 16 Aug 2018 12:16:07 -0400 Date: Thu, 16 Aug 2018 06:17:31 -0700 From: Luis Chamberlain To: Srikanth K H Cc: keescook@chromium.org, adobriyan@gmail.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/1] Preventive patch in the proc file-system to handle NULL check. Message-ID: <20180816131731.GB1457@garbanzo.do-not-panic.com> References: <1534412053-22457-1-git-send-email-srikanth.h@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1534412053-22457-1-git-send-email-srikanth.h@samsung.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Aug 16, 2018 at 03:04:13PM +0530, Srikanth K H wrote: > If the make directory for "sys" interface fail's then its > dereferenced without even checking for its validity which > will lead to crash, hence added preventive code to check > for NULL and accordingly dereference. > > Signed-off-by: Srikanth K H Thanks for the patch! Do you have a reproducer or is this theoretical? This will affect if it should go to stable or not. Luis