From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:33736 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725853AbeHRFPT (ORCPT ); Sat, 18 Aug 2018 01:15:19 -0400 Date: Fri, 17 Aug 2018 19:09:28 -0700 From: Matthew Wilcox To: Jiecheng Wu Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] fs/namespace.c: fix missing return value check of ida_pre_get() Message-ID: <20180818020928.GB14115@bombadil.infradead.org> References: <20180818020300.4296-1-jasonwood2031@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180818020300.4296-1-jasonwood2031@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Aug 18, 2018 at 10:03:00AM +0800, Jiecheng Wu wrote: > Function mnt_alloc_id() defined in fs/namespace.c calls ida_pre_get() to allocate memory. It may return 0 on failure. The return code should be checked against 0. Please ignore as I've ripped all this code out in: http://git.infradead.org/users/willy/linux-dax.git/commitdiff/4d1a8396bab0644d4d444dd28c0d622a22f39939?hp=20015ec08dd23a69776d86258c98e9b729dede8c which is queued for Linus this merge window.