archive mirror
 help / color / mirror / Atom feed
From: Dave Chinner <>
To: Andrei Vagin <>
Cc: David Howells <>,, Andrei Vagin <>
Subject: Re: [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API
Date: Tue, 21 Aug 2018 09:47:29 +1000	[thread overview]
Message-ID: <20180820234729.GH31495@dastard> (raw)
In-Reply-To: <>

On Fri, Aug 10, 2018 at 03:00:27PM -0700, Andrei Vagin wrote:
> From: Andrei Vagin <>
> Currently, a reconfigure call-back is implemented only for the proc file
> system. This test creates a new mount and pid namespace and then we can
> create a new proc mount instance and be sure that a host configuration
> will not be affected.
> Signed-off-by: Andrei Vagin <>
> ---
>  tools/testing/selftests/fsopen/Makefile |   5 +
>  tools/testing/selftests/fsopen/config   |   2 +
>  tools/testing/selftests/fsopen/fsopen.c | 120 ++++++++++++++++++++++++
>  3 files changed, 127 insertions(+)
>  create mode 100644 tools/testing/selftests/fsopen/Makefile
>  create mode 100644 tools/testing/selftests/fsopen/config
>  create mode 100644 tools/testing/selftests/fsopen/fsopen.c

can we get all this test stuff put into fstests?

And then add a config option to the fstests mount commands so that
they use the internal mount command to exercise the new API rather
than use the existing mount binary?

That way every filesystem developer /will/ exercise the new mount
API in lots of interesting and unusual ways that are expected to
work (or not work, as fstests exercises failure cases, too) in their
day-to-day testing and development. This will flush out the bugs and
problems much, much faster than a small selftest in the kernel tree
that doesn't really interact with the bulk of the code that runs
when filesystems are mounted/remounted.


Dave Chinner

  reply	other threads:[~2018-08-21  3:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-10 22:00 [PATCH dhowells/mount-api 1/2] fs/fsconfig: handle FSCONFIG_CMD_RECONFIGURE Andrei Vagin
2018-08-10 22:00 ` [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API Andrei Vagin
2018-08-20 23:47   ` Dave Chinner [this message]
2018-08-10 22:52 ` [PATCH dhowells/mount-api 1/2] fs/fsconfig: handle FSCONFIG_CMD_RECONFIGURE David Howells
2018-08-10 22:55 ` [PATCH dhowells/mount-api 2/2] selftests: implement a test for a new mount API David Howells
2018-08-20 23:29   ` Andrei Vagin
2018-08-21  9:19   ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180820234729.GH31495@dastard \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).