From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.linuxfoundation.org ([140.211.169.12]:59258 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727247AbeHVC1f (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 21 Aug 2018 22:27:35 -0400
Date: Tue, 21 Aug 2018 16:05:25 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Viacheslav Dubeyko <slava@dubeyko.com>
Cc: "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?=
        <ernesto.mnd.fernandez@gmail.com>, linux-fsdevel@vger.kernel.org,
        "Xu, Wen" <wen.xu@gatech.edu>
Subject: Re: [PATCH] hfsplus: fix NULL dereference in hfsplus_lookup()
Message-Id: <20180821160525.83c7cb950e26164803977857@linux-foundation.org>
In-Reply-To: <1531436133.22955.4.camel@slavad-ubuntu-14.04>
References: <20180712215344.q44dyrhymm4ajkao@eaf>
        <1531436133.22955.4.camel@slavad-ubuntu-14.04>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 12 Jul 2018 15:55:33 -0700 Viacheslav Dubeyko <slava@dubeyko.com> wrote:

> On Thu, 2018-07-12 at 18:53 -0300, Ernesto A. Fern�ndez wrote:
> > Check that the hidden directory is not NULL before using it, instead of
> > after.
> > 
> > Reported-by: Wen Xu <wen.xu@gatech.edu>
> > Signed-off-by: Ernesto A. Fern�ndez <ernesto.mnd.fernandez@gmail.com>
> > ---
> 
> It's really hard to understand this simple patch. I believe it makes
> sense to rework the patch slightly with the goal to make it more clear.
> Also, it will be great to add a short comment in the code to explain
> what's wrong.
> 
> I think it makes sense to split this long check condition on something
> more clear, simple and elegant.

No response, causing this patch to be stuck in limbo land?