From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f182.google.com ([209.85.216.182]:36083 "EHLO mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbeHVWMX (ORCPT ); Wed, 22 Aug 2018 18:12:23 -0400 Received: by mail-qt0-f182.google.com with SMTP id t5-v6so3337738qtn.3 for ; Wed, 22 Aug 2018 11:46:21 -0700 (PDT) Date: Wed, 22 Aug 2018 15:46:16 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: Andrew Morton Cc: Viacheslav Dubeyko , linux-fsdevel@vger.kernel.org, "Xu, Wen" Subject: Re: [PATCH] hfsplus: fix NULL dereference in hfsplus_lookup() Message-ID: <20180822184616.3cm43dxzsijfayq7@eaf> References: <20180712215344.q44dyrhymm4ajkao@eaf> <1531436133.22955.4.camel@slavad-ubuntu-14.04> <20180821160525.83c7cb950e26164803977857@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180821160525.83c7cb950e26164803977857@linux-foundation.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Aug 21, 2018 at 04:05:25PM -0700, Andrew Morton wrote: > On Thu, 12 Jul 2018 15:55:33 -0700 Viacheslav Dubeyko wrote: > > > On Thu, 2018-07-12 at 18:53 -0300, Ernesto A. Fernández wrote: > > > Check that the hidden directory is not NULL before using it, instead of > > > after. > > > > > > Reported-by: Wen Xu > > > Signed-off-by: Ernesto A. Fernández > > > --- > > > > It's really hard to understand this simple patch. I believe it makes > > sense to rework the patch slightly with the goal to make it more clear. > > Also, it will be great to add a short comment in the code to explain > > what's wrong. I don't think it's reasonable to expect a comment explaining why we can't dereference NULL. > > I think it makes sense to split this long check condition on something > > more clear, simple and elegant. The long check condition may not be ideal, but there's a lot of code in the module that could use style improvements. I don't think that should be a priority right now, with plenty of serious bugs left to fix. > > No response, causing this patch to be stuck in limbo land? I believe I sent a second version of this patch. Ernest