From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f194.google.com ([209.85.216.194]:45836 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726780AbeHWWAT (ORCPT ); Thu, 23 Aug 2018 18:00:19 -0400 Received: by mail-qt0-f194.google.com with SMTP id g44-v6so6693935qtb.12 for ; Thu, 23 Aug 2018 11:29:23 -0700 (PDT) Date: Thu, 23 Aug 2018 15:29:16 -0300 From: Ernesto =?utf-8?Q?A=2E_Fern=C3=A1ndez?= To: tchou Cc: slava@dubeyko.com, linux-fsdevel@vger.kernel.org, htl10@users.sourceforge.net Subject: Re: [PATCH] hfsplus: fix decomposition of Hangul characters Message-ID: <20180823182916.ajyci6expu535dcf@eaf> References: <1510906805-2142-1-git-send-email-tchou@synology.com> <20171119005704.GA3495@debian.home> <080024a85dc413b72c181c6e75bdc736@synology.com> <20171123113230.GA5581@debian.home> <1028889c01cdd513c2cf8cabf6c1762e@synology.com> <20171124114525.GA3265@debian.home> <510d6873cbcd4d93f0902c62e3a2c22d@synology.com> <20171127193652.GA3690@debian.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171127193652.GA3690@debian.home> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi again: On Mon, Nov 27, 2017 at 04:36:54PM -0300, Ernesto A. Fernández wrote: > It would be good to have some feedback on the use of code under the > Unicode License, I don't know if that can be a problem. > > To Ting-Chang Hou: This patch is slightly different from the one you > tested with your mac. You are still tagged as Tested-by, but you may > want to check again that I have not broken anything. > > Thanks, > Ernest > > -- >8 -- > Subject: [PATCH] hfsplus: fix decomposition of Hangul characters > > Files created under macOS become essentially unusable under linux if > their names contain any Hangul, and vice versa. > > This happens because the normalization of Hangul characters is a special > case: it can be done algorithmically, without need of a table. The > hfsplus module deals with Hangul correctly when composing, but > completely forgets about it when performing a decomposition. > > Solve this by using the Hangul decomposition function provided in the > Unicode Standard. It's under the Unicode License, compatible with the > GPL. > > This patch will cause trouble for Hangul filenames already created by > the module in the past. This shouldn't be a special concern because the > main purpose of the module was always sharing with macOS. If a user > actually needs to access such a file the nodecompose mount option should > be enough. > > Reported-by: Ting-Chang Hou > Tested-by: Ting-Chang Hou > Signed-off-by: Ernesto A. Fernández > It took a while but this patch has been merged now. Thanks again for your report. Ernest