From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 28 Aug 2018 16:01:50 -0700 From: Andrew Morton To: Waiman Long Cc: Alexander Viro , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, "Luis R. Rodriguez" , Kees Cook , Linus Torvalds , Jan Kara , "Paul E. McKenney" , Ingo Molnar , Miklos Szeredi , Matthew Wilcox , Larry Woodman , James Bottomley , "Wangkai (Kevin C)" , Michal Hocko Subject: Re: [PATCH 2/2] fs/dcache: Make negative dentries easier to be reclaimed Message-Id: <20180828160150.9a45ee293c92708edb511eab@linux-foundation.org> In-Reply-To: <1535476780-5773-3-git-send-email-longman@redhat.com> References: <1535476780-5773-1-git-send-email-longman@redhat.com> <1535476780-5773-3-git-send-email-longman@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: Another pet peeve ;) On Tue, 28 Aug 2018 13:19:40 -0400 Waiman Long wrote: > /** > + * list_lru_add_head: add an element to the lru list's head > + * @list_lru: the lru pointer > + * @item: the item to be added. > + * > + * This is similar to list_lru_add(). The only difference is the location > + * where the new item will be added. The list_lru_add() function will add People often use the term "the foo() function". I don't know why - just say "foo()"! > + * the new item to the tail as it is the most recently used one. The > + * list_lru_add_head() will add the new item into the head so that it Ditto. "to the head" > + * will the first to go if a shrinker is running. So this function should "will be the" > + * only be used for less important item that can be the first to go if "items" > + * the system is under memory pressure. > + * > + * Return value: true if the list was updated, false otherwise > + */