From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: akpm@linux-foundation.org, konishi.ryusuke@lab.ntt.co.jp,
viro@zeniv.linux.org.uk, tytso@mit.edu, adilger.kernel@dilger.ca,
axboe@kernel.dk, darrick.wong@oracle.com, ebiggers@google.com,
pombredanne@nexb.com, agruenba@redhat.com,
gregkh@linuxfoundation.org, kemi.wang@intel.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-nilfs@vger.kernel.org
Subject: Re: [PATCH v2] fs: Convert return type int to vm_fault_t
Date: Sun, 2 Sep 2018 21:49:49 -0700 [thread overview]
Message-ID: <20180903044949.GB17856@bombadil.infradead.org> (raw)
In-Reply-To: <20180830172547.GA4408@jordon-HP-15-Notebook-PC>
On Thu, Aug 30, 2018 at 10:55:47PM +0530, Souptick Joarder wrote:
> +vm_fault_t block_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf,
> + get_block_t get_block, int *err)
I don't like returning both the errno and the vm_fault_t. To me that's a
sign we need to rethink this interface.
I have two suggestions. First, we could allocate a new VM_FAULT_NOSPC
bit. Second, we could repurpose one of the existing bits, such as
VM_FAULT_RETRY for this purpose.
> -int ext4_page_mkwrite(struct vm_fault *vmf)
> +vm_fault_t ext4_page_mkwrite(struct vm_fault *vmf)
I also think perhaps we could start by _not_ converting block_page_mkwrite().
Just convert ext4_page_mkwrite(), and save converting block_page_mkwrite()
for later.
prev parent reply other threads:[~2018-09-03 9:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-30 17:25 [PATCH v2] fs: Convert return type int to vm_fault_t Souptick Joarder
2018-08-30 23:33 ` Andrew Morton
2018-08-31 6:03 ` Souptick Joarder
2018-09-04 0:28 ` Andrew Morton
2018-09-04 2:13 ` Matthew Wilcox
2018-09-03 2:13 ` Ryusuke Konishi
2018-09-03 11:58 ` Souptick Joarder
2018-08-30 23:35 ` Andrew Morton
2018-08-31 16:58 ` Theodore Y. Ts'o
2018-09-01 16:21 ` Souptick Joarder
2018-09-03 4:49 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180903044949.GB17856@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=adilger.kernel@dilger.ca \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=darrick.wong@oracle.com \
--cc=ebiggers@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jrdr.linux@gmail.com \
--cc=kemi.wang@intel.com \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nilfs@vger.kernel.org \
--cc=pombredanne@nexb.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).