From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com ([209.85.208.195]:38721 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727645AbeIGUzy (ORCPT ); Fri, 7 Sep 2018 16:55:54 -0400 From: Igor Stoppa To: Alexander Viro Cc: igor.stoppa@gmail.com, Igor Stoppa , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] filesystems: remove unnecessary unlikely() Date: Fri, 7 Sep 2018 19:14:05 +0300 Message-Id: <20180907161405.23761-1-igor.stoppa@huawei.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: WARN_ON() already contains an unlikely(), so it's not necessary to wrap it into another. Signed-off-by: Igor Stoppa Cc: Alexander Viro Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/open.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/open.c b/fs/open.c index 0285ce7dbd51..19a9e4b378d3 100644 --- a/fs/open.c +++ b/fs/open.c @@ -750,7 +750,7 @@ static int do_dentry_open(struct file *f, f->f_mode |= FMODE_ATOMIC_POS; f->f_op = fops_get(inode->i_fop); - if (unlikely(WARN_ON(!f->f_op))) { + if (WARN_ON(!f->f_op)) { error = -ENODEV; goto cleanup_all; } -- 2.17.1