From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f174.google.com ([209.85.215.174]:36030 "EHLO mail-pg1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbeIKKJe (ORCPT ); Tue, 11 Sep 2018 06:09:34 -0400 Received: by mail-pg1-f174.google.com with SMTP id d1-v6so11619754pgo.3 for ; Mon, 10 Sep 2018 22:12:05 -0700 (PDT) Date: Mon, 10 Sep 2018 22:12:02 -0700 From: Andrei Vagin To: David Howells Cc: Andrei Vagin , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH dhowells/mount-api] fs: fix checking an error code of security_fs_context_parse_param Message-ID: <20180911051200.GA25877@gmail.com> References: <18703.1536228984@warthog.procyon.org.uk> <20180906001051.24015-1-avagin@openvz.org> <19052.1536229132@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <19052.1536229132@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Sep 06, 2018 at 11:18:52AM +0100, David Howells wrote: > > The change that needs making is to the documentation - in particular > > lsm_hooks.h. > > And also the default for security_fs_context_parse_param() needs changing to > -ENOPARAM. apparmor_fs_context_parse_param() should be fixed too, it never returns -ENOPARAM. > > David