linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Elliott, Robert (Persistent Memory)" <elliott@hpe.com>
Cc: "Kani, Toshi" <toshi.kani@hpe.com>, "jack@suse.cz" <jack@suse.cz>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: open sets ext4_da_aops for DAX existing files
Date: Tue, 11 Sep 2018 17:27:06 +0200	[thread overview]
Message-ID: <20180911152706.GG6104@quack2.suse.cz> (raw)
In-Reply-To: <AT5PR8401MB1169A490CF0565CAD12ACC3DAB050@AT5PR8401MB1169.NAMPRD84.PROD.OUTLOOK.COM>

On Mon 10-09-18 17:58:10, Elliott, Robert (Persistent Memory) wrote:
> 
> 
> > -----Original Message-----
> > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Kani, Toshi
> > Sent: Monday, September 10, 2018 9:52 AM
> > To: jack@suse.cz
> > Cc: linux-fsdevel@vger.kernel.org; linux-nvdimm@lists.01.org
> > Subject: Re: open sets ext4_da_aops for DAX existing files
> ...
> > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier
> > > in the ext4_iget()? Did this bug have any user visible manifestations?
> > 
> > Yes, sync did not flush processor cache.
> > 
> > > Please also add:
> > >
> > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086
> > >
> > > so that stable automation picks this up. Thanks!
> > >
> > 
> > Will do.
> > 
> 
> Also check if the same problem exists with ext2.

The problem also exists in ext2 so that needs fixing as well.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR

  reply	other threads:[~2018-09-11 20:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 21:23 Kani, Toshi
2018-09-10 12:54 ` Jeff Moyer
2018-09-10 14:21   ` Kani, Toshi
2018-09-10 14:26     ` Dan Williams
2018-09-10 14:29 ` Jan Kara
2018-09-10 14:51   ` Kani, Toshi
2018-09-10 17:58     ` Elliott, Robert (Persistent Memory)
2018-09-11 15:27       ` Jan Kara [this message]
2018-09-11 16:34         ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180911152706.GG6104@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=elliott@hpe.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=toshi.kani@hpe.com \
    --subject='Re: open sets ext4_da_aops for DAX existing files' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).