From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from verein.lst.de ([213.95.11.211]:57761 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727623AbeINSiT (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 14 Sep 2018 14:38:19 -0400
Date: Fri, 14 Sep 2018 15:23:53 +0200
From: Christoph Hellwig <hch@lst.de>
To: Carlos Maiolino <cmaiolino@redhat.com>
Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, sandeen@redhat.com,
        david@fromorbit.com
Subject: Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
Message-ID: <20180914132352.GB27382@lst.de>
References: <20180912122536.31977-1-cmaiolino@redhat.com> <20180912122536.31977-3-cmaiolino@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180912122536.31977-3-cmaiolino@redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, Sep 12, 2018 at 02:25:35PM +0200, Carlos Maiolino wrote:
> Replace the direct usage of ->bmap method by a bmap() call.

Would be nice to have some real error handling instead of the assert
on an error return, but otherwise this looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>