linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Maiolino <cmaiolino@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, sandeen@redhat.com, david@fromorbit.com
Subject: Re: [PATCH 2/3] cachefiles: drop direct usage of ->bmap method.
Date: Fri, 14 Sep 2018 20:56:50 +0200	[thread overview]
Message-ID: <20180914185650.2qd4zsza6kne2clp@odin.usersys.redhat.com> (raw)
In-Reply-To: <20180914132352.GB27382@lst.de>

On Fri, Sep 14, 2018 at 03:23:53PM +0200, Christoph Hellwig wrote:
> On Wed, Sep 12, 2018 at 02:25:35PM +0200, Carlos Maiolino wrote:
> > Replace the direct usage of ->bmap method by a bmap() call.
> 
> Would be nice to have some real error handling instead of the assert
> on an error return, but otherwise this looks fine:
> 

Thanks. I'll see if I can do something about it and write a patch for it. /me
doesn't know much about cachefiles yet.

Thanks for the review.

Cheers

> Reviewed-by: Christoph Hellwig <hch@lst.de>

-- 
Carlos

  reply	other threads:[~2018-09-15  0:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 12:25 [PATCH 0/3] Replace direct ->bmap calls by bmap() with error support Carlos Maiolino
2018-09-12 12:25 ` [PATCH 1/3] fs: Enable bmap() function to properly return errors Carlos Maiolino
2018-09-14 13:23   ` Christoph Hellwig
2018-09-14 18:48     ` Carlos Maiolino
2018-09-17 20:55   ` Darrick J. Wong
2018-09-18  6:00     ` Carlos Maiolino
2018-09-12 12:25 ` [PATCH 2/3] cachefiles: drop direct usage of ->bmap method Carlos Maiolino
2018-09-14 13:23   ` Christoph Hellwig
2018-09-14 18:56     ` Carlos Maiolino [this message]
2018-09-12 12:25 ` [PATCH 3/3] ecryptfs: drop direct calls to ->bmap Carlos Maiolino
2018-09-14 13:26   ` Christoph Hellwig
2018-09-14 18:47     ` Carlos Maiolino
2018-09-17 11:04   ` [PATCH 3/3 V2] " Carlos Maiolino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914185650.2qd4zsza6kne2clp@odin.usersys.redhat.com \
    --to=cmaiolino@redhat.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).