From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:56216 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726849AbeIOAeI (ORCPT ); Fri, 14 Sep 2018 20:34:08 -0400 Date: Fri, 14 Sep 2018 15:13:28 -0400 From: Richard Guy Briggs To: Jan Kara Cc: Paul Moore , Al Viro , linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, Amir Goldstein Subject: Re: [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Message-ID: <20180914191328.rljpiakvk4xavrzj@madcap2.tricolour.ca> References: <20180904160632.21210-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180904160632.21210-1-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2018-09-04 18:06, Jan Kara wrote: > Hello, Jan, > this is the third revision of the series that addresses problems I have > identified when trying to understand how exactly is kernel/audit_tree.c using > generic fsnotify framework. I hope I have understood all the interactions right > but careful review is certainly welcome. I've tried to review it as carefully as I am able. As best I understand it, this all looks reasonable and an improvement over the previous state. Thanks for the hard work. FWIW, Reviewed-by: Richard Guy Briggs > The patches have been tested by a stress test I have written which mounts & > unmounts filesystems in the directory tree while adding and removing audit > rules for this tree in parallel and accessing the tree to generate events. > Still some real-world testing would be welcome. > > Changes since v2: > * Fixed up mark freeing to use proper pointer as pointed out by Amir > * Changed some naming based on Paul's review > > Changes since v1: > * Split the last patch to ease review > * Rewrite test script so that it can be included in audit testsuite > * Some cleanups and improvements suggested by Amir > > Honza - RGB -- Richard Guy Briggs Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada IRC: rgb, SunRaycer Voice: +1.647.777.2635, Internal: (81) 32635