From: Josef Bacik <josef@toxicpanda.com>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com, linux-btrfs@vger.kernel.org, riel@redhat.com,
hannes@cmpxchg.org, tj@kernel.org, linux-mm@kvack.org,
linux-fsdevel@vger.kernel.org
Cc: Johannes Weiner <jweiner@fb.com>
Subject: [PATCH 4/8] mm: drop mmap_sem for swap read IO submission
Date: Tue, 25 Sep 2018 11:30:07 -0400 [thread overview]
Message-ID: <20180925153011.15311-5-josef@toxicpanda.com> (raw)
In-Reply-To: <20180925153011.15311-1-josef@toxicpanda.com>
From: Johannes Weiner <jweiner@fb.com>
We don't need to hold the mmap_sem while we're doing the IO, simply drop
it and retry appropriately.
Signed-off-by: Johannes Weiner <jweiner@fb.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
---
mm/page_io.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/mm/page_io.c b/mm/page_io.c
index aafd19ec1db4..bf21b56a964e 100644
--- a/mm/page_io.c
+++ b/mm/page_io.c
@@ -365,6 +365,20 @@ int swap_readpage(struct page *page, bool synchronous)
goto out;
}
+ /*
+ * XXX:
+ *
+ * Propagate mm->mmap_sem into this function. Then:
+ *
+ * get_file(sis->swap_file)
+ * up_read(mm->mmap_sem)
+ * submit io request
+ * fput
+ *
+ * After mmap_sem is dropped, sis is no longer valid. Go
+ * through swap_file->blah->bdev.
+ */
+
if (sis->flags & SWP_FILE) {
struct file *swap_file = sis->swap_file;
struct address_space *mapping = swap_file->f_mapping;
--
2.14.3
next prev parent reply other threads:[~2018-09-25 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 15:30 [RFC][PATCH 0/8] drop the mmap_sem when doing IO in the fault path Josef Bacik
2018-09-25 15:30 ` [PATCH 1/8] mm: push vm_fault into the page fault handlers Josef Bacik
2018-09-26 0:22 ` Dave Chinner
2018-09-26 1:33 ` Josef Bacik
2018-09-25 15:30 ` [PATCH 2/8] mm: drop mmap_sem for page cache read IO submission Josef Bacik
2018-09-25 15:30 ` [PATCH 3/8] mm: clean up swapcache lookup and creation function names Josef Bacik
2018-09-25 15:30 ` Josef Bacik [this message]
2018-09-25 15:30 ` [PATCH 5/8] mm: drop the mmap_sem in all read fault cases Josef Bacik
2018-09-25 15:30 ` [PATCH 6/8] mm: keep the page we read for the next loop Josef Bacik
2018-09-25 15:30 ` [PATCH 7/8] mm: add a flag to indicate we used a cached page Josef Bacik
2018-09-25 15:30 ` [PATCH 8/8] btrfs: drop mmap_sem in mkwrite for btrfs Josef Bacik
2018-09-26 0:24 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925153011.15311-5-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=jweiner@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).