From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-ot1-f66.google.com ([209.85.210.66]:46195 "EHLO
        mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726150AbeI1FKh (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 28 Sep 2018 01:10:37 -0400
Received: by mail-ot1-f66.google.com with SMTP id q4-v6so4172624otf.13
        for <linux-fsdevel@vger.kernel.org>; Thu, 27 Sep 2018 15:50:00 -0700 (PDT)
Date: Thu, 27 Sep 2018 16:49:51 -0600
From: Tycho Andersen <tycho@tycho.ws>
To: Jann Horn <jannh@google.com>
Cc: Kees Cook <keescook@chromium.org>,
        kernel list <linux-kernel@vger.kernel.org>,
        containers@lists.linux-foundation.org,
        Linux API <linux-api@vger.kernel.org>,
        Andy Lutomirski <luto@amacapital.net>,
        Oleg Nesterov <oleg@redhat.com>,
        "Eric W. Biederman" <ebiederm@xmission.com>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Tyler Hicks <tyhicks@canonical.com>,
        suda.akihiro@lab.ntt.co.jp, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v7 5/6] seccomp: add a way to pass FDs via a notification
 fd
Message-ID: <20180927224951.GG15491@cisco.cisco.com>
References: <20180927151119.9989-1-tycho@tycho.ws>
 <20180927151119.9989-6-tycho@tycho.ws>
 <CAG48ez0JY=_fvgy+t92-08kBFgTAZ-3hgAp+OOAwmSd73MJ-QA@mail.gmail.com>
 <20180927221408.GD15491@cisco.cisco.com>
 <CAG48ez3LYZiEQJKf+6UxjeM0L7FXEq_qxZVb=O=sJeQ2DadbNg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG48ez3LYZiEQJKf+6UxjeM0L7FXEq_qxZVb=O=sJeQ2DadbNg@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Sep 28, 2018 at 12:17:07AM +0200, Jann Horn wrote:
> On Fri, Sep 28, 2018 at 12:14 AM Tycho Andersen <tycho@tycho.ws> wrote:
> > On Thu, Sep 27, 2018 at 09:28:07PM +0200, Jann Horn wrote:
> > > On Thu, Sep 27, 2018 at 5:11 PM Tycho Andersen <tycho@tycho.ws> wrote:
> > > > This patch adds a way to insert FDs into the tracee's process (also
> > > > close/overwrite fds for the tracee). This functionality is necessary to
> > > > mock things like socketpair() or dup2() or similar, but since it depends on
> > > > external (vfs) patches, I've left it as a separate patch as before so the
> > > > core functionality can still be merged while we argue about this. Except
> > > > this time it doesn't add any ugliness to the API :)
> > > [...]
> > > > +static long seccomp_notify_put_fd(struct seccomp_filter *filter,
> > > > +                                 unsigned long arg)
> > > > +{
> > > > +       struct seccomp_notif_put_fd req;
> > > > +       void __user *buf = (void __user *)arg;
> > > > +       struct seccomp_knotif *knotif = NULL;
> > > > +       long ret;
> > > > +
> > > > +       if (copy_from_user(&req, buf, sizeof(req)))
> > > > +               return -EFAULT;
> > > > +
> > > > +       if (req.fd < 0 && req.to_replace < 0)
> > > > +               return -EINVAL;
> > > > +
> > > > +       ret = mutex_lock_interruptible(&filter->notify_lock);
> > > > +       if (ret < 0)
> > > > +               return ret;
> > > > +
> > > > +       ret = -ENOENT;
> > > > +       list_for_each_entry(knotif, &filter->notif->notifications, list) {
> > > > +               struct file *file = NULL;
> > > > +
> > > > +               if (knotif->id != req.id)
> > > > +                       continue;
> > >
> > > Are you intentionally permitting non-SENT states here? It shouldn't
> > > make a big difference, but I think it'd be nice to at least block the
> > > use of notifications in SECCOMP_NOTIFY_REPLIED state.
> >
> > Agreed, I'll block everything besides REPLIED.
> 
> Do you mean SENT? In REPLIED state, seccomp_notify_put_fd()
> is racy because the target task is in the process of waking up, right?

Yes, sorry, I mean SENT.

Tycho