From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:42354 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726738AbeI1XGk (ORCPT ); Fri, 28 Sep 2018 19:06:40 -0400 Date: Fri, 28 Sep 2018 09:42:04 -0700 From: Matthew Wilcox To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] fuse: allow caching readdir Message-ID: <20180928164204.GA20414@bombadil.infradead.org> References: <20180928154234.19270-1-mszeredi@redhat.com> <20180928154234.19270-5-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180928154234.19270-5-mszeredi@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 05:42:29PM +0200, Miklos Szeredi wrote: > @@ -103,6 +103,21 @@ struct fuse_inode { > /** List of writepage requestst (pending or sent) */ > struct list_head writepages; > > + /** readdir cache */ > + struct { > + /** true if fully cached */ > + bool cached; umm, you're using kernel-doc markers without formatting this comment as kernel-doc. See Documentation/doc-guide/kernel-doc.rst but I believe you should be writing this as: /** @rdc.cached: true if fully cached */ or just use /* */ if you don't want kernel-doc.