From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:58742 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbeJBGON (ORCPT ); Tue, 2 Oct 2018 02:14:13 -0400 Date: Mon, 1 Oct 2018 16:33:36 -0700 From: "Darrick J. Wong" To: Dave Chinner Cc: viro@ZenIV.linux.org.uk, xfs , linux-fsdevel , Christoph Hellwig Subject: Re: [PATCH] vfs: check ->get_link return value Message-ID: <20181001233336.GF5872@magnolia> References: <20181001224500.GE5872@magnolia> <20181001232128.GL18567@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181001232128.GL18567@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Oct 02, 2018 at 09:21:28AM +1000, Dave Chinner wrote: > On Mon, Oct 01, 2018 at 03:45:00PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Teach callers of inode->i_op->get_link in the vfs code to check for a > > NULL return value and return an error status instead of blindly > > dereferencing the returned NULL pointer. > > > > Signed-off-by: Darrick J. Wong > > --- > > fs/namei.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/fs/namei.c b/fs/namei.c > > index 0cab6494978c..0744ab981fa0 100644 > > --- a/fs/namei.c > > +++ b/fs/namei.c > > @@ -4737,6 +4737,8 @@ int vfs_readlink(struct dentry *dentry, char __user *buffer, int buflen) > > if (IS_ERR(link)) > > return PTR_ERR(link); > > } > > + if (!link) > > + return -EUCLEAN; > > If we are going to start returning this as a filesystem corruption > error from the VFS, can we please start with adding > > #define EFSCORRUPTED EUCLEAN > > into one of the global error definition headers? The code makes much > more sense when it uses EFSCORRUPTED.... Ok, which header file? include/uapi/asm-generic/errno.h ? We'll finally be able to get rid of the redundant definitions in ext[24] too. --D > Cheers, > > Dave. > -- > Dave Chinner > david@fromorbit.com