From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:48488 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726857AbeJDPdx (ORCPT ); Thu, 4 Oct 2018 11:33:53 -0400 Date: Thu, 4 Oct 2018 10:41:41 +0200 From: Jan Kara To: Amir Goldstein Cc: Jan Kara , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v3 6/8] fanotify: add BUILD_BUG_ON() to count the bits of fanotify constants Message-ID: <20181004084141.GA11529@quack2.suse.cz> References: <20181003212539.2384-1-amir73il@gmail.com> <20181003212539.2384-7-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181003212539.2384-7-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 04-10-18 00:25:37, Amir Goldstein wrote: > Also define the FANOTIFY_EVENT_FLAGS consisting of the extra flags > FAN_ONDIR and FAN_ON_CHILD. > > Signed-off-by: Amir Goldstein ... > /* Events that may be reported to user */ > #define FANOTIFY_OUTGOING_EVENTS (FANOTIFY_EVENTS | \ > FANOTIFY_PERM_EVENTS | \ > FAN_Q_OVERFLOW) > > +#define ALL_FANOTIFY_EVENT_BITS (FANOTIFY_EVENTS | \ > + FANOTIFY_PERM_EVENTS | \ > + FANOTIFY_EVENT_FLAGS | \ > + FANOTIFY_OUTGOING_EVENTS) > + No point in repeating FANOTIFY_EVENTS | FANOTIFY_PERM_EVENTS here when they are already included on FANOTIFY_OUTGOING_EVENTS, right? I can fix that up myself, just wanted to point it out. Honza -- Jan Kara SUSE Labs, CR