From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:37161 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbeJFRCc (ORCPT ); Sat, 6 Oct 2018 13:02:32 -0400 Date: Sat, 6 Oct 2018 11:59:51 +0200 From: Christoph Hellwig To: Carlos Maiolino Cc: linux-fsdevel@vger.kernel.org, okozina@redhat.com, hch@lst.de Subject: Re: [RFC PATCH] iomap: Enable alignment check for iomap DIO in holes Message-ID: <20181006095951.GA6047@lst.de> References: <20181005130316.4869-1-cmaiolino@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181005130316.4869-1-cmaiolino@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Oct 05, 2018 at 03:03:16PM +0200, Carlos Maiolino wrote: > Commit 09230435dffdb13de507e5e40b524b0069fc5c7b refactor iomap_dio_actor > into two different helpers for bio based IO and hole IO, although, the > latter doesn't check for IO alignment anymore. > > Move the DIO alignment check up into the caller, so all iomap DIO has > alignment checked. Why? The only reason to check alignmnet for actual I/O is because we have to. There is no requirement to align holes. > Christoph, I tagged this patch as RFC, because I couldn't really identify if you > intentionally dropped the alignment check for holes and inline actors, if you > didn't drop the alignment check intentionally, please consider it as a normal > patch. The primary intent was to simplify the code and not enforce alignment for inline data support.